[Star Tree] Multiple Star Trees and Added Tests #16124
Conversation
|
❌ Gradle check result for 024e21a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sarthakaggarwal97
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
startree-tests
branch
from
024e21a
to
918da42
Compare
|
❌ Gradle check result for 918da42: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| @@ -35,7 +35,7 @@ public class StarTreeIndexSettings { | |||
| "index.composite_index.star_tree.max_fields", | |||
| 1, | |||
| 1, | |||
| 1, | |||
| 2, | |||
There was a problem hiding this comment.
By doing this, aren't we allowing users as well to create multiple star trees ? can we check if there are any better ways to do this.
There was a problem hiding this comment.
yes, we can wait to merge this PR. Since you have taken the fixes in the #16380, logically we should not face issues in multi star tree.
Once we would want to support the multiple star tree, we can merge this PR alongside the test.
|
Multi Star Tree fixes are now taken over here: #16380 |
Description
This changes allows us to make multiple star trees (2 for now) per segment. This test also includes the tests to validate multiple star trees.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.