Fix flaky date histo rest test #16067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 719a67f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 719a67f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Sep 24, 2024
|
❌ Gradle check result for 719a67f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Finn Carroll <carrofin@amazon.com>
finnegancarroll
force-pushed
the
fixflakyagg
branch
from
719a67f
to
e2e8b45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16067 +/- ##
============================================
+ Coverage 71.99% 72.01% +0.02%
- Complexity 64377 64425 +48
============================================
Files 5281 5281
Lines 301068 301068
Branches 43493 43493
============================================
+ Hits 216740 216808 +68
+ Misses 66504 66474 -30
+ Partials 17824 17786 -38 ☔ View full report in Codecov by Sentry. |
finnegancarroll
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis and
gbbafna
as code owners
finnegancarroll
requested review from
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
mch2
approved these changes
Sep 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Finn Carroll <carrofin@amazon.com> (cherry picked from commit a42e51d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
that referenced
this pull request
Oct 1, 2024
(cherry picked from commit a42e51d) Signed-off-by: Finn Carroll <carrofin@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Finn Carroll <carrofin@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Finn Carroll <carrofin@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Finn Carroll <carrofin@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
yaml=search.aggregation/360_date_histogram/Date histogram aggregation w/ shared field range testis flaky because it assumes there will only be a single segment created for the test index.Previously fixed for other similar tests but this test is missing changes which guarantee a single segment:
#14486
Related Issues
#14408
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.