Add changes to block calls in cat shards, indices and segments based on dynamic limit settings #15986

sumitasr · 2024-09-18T22:13:08Z

Add changes to block calls in cat shards, indices and segments based on dynamic limit settings

Description

Introduced a new class RequestLimitSettings to maintain dynamic settings for 3 actions - cat indices, shards and segments and method to evaluate if circuitLimitBreached for an action.
- cat.indices.response.limit.number_of_indices (The limit will be applied on number of indices)
- cat.shards.response.limit.number_of_shards (The limit will be applied on number of shards)
- cat.segments.response.limit.number_of_indices (The limit will be applied on number of indices)
Introduced isRequestLimitCheckSupported method defaulting to false in AbstractCatAction so that we can override this if an action extending AbstractCatAction can define if it supports limit or circuit breaker checks introduced in RequestLimitSettings class. This value can be passed to respected transport action as param e.g. TransportCatShardsAction
If circuit limit breached, CircuitBreakingException will be raised which is mapped to 429 error code.

Related Issues

Resolves #15954

Functional Testing

(Outdated - Exception scenario response format has been modified)

Action 1 : /_cat/shards/

Step 1 - Run OS cluster locally

Step 2 - PUT 3 index

Step 3 - Perform /_cat/shards/

curl -XGET "http://localhost:9200/_cat/shards/"
1index 0 p STARTED 1 4.7kb 127.0.0.1 runTask-0
1index 0 r UNASSIGNED
2index 0 p STARTED 1 4.7kb 127.0.0.1 runTask-0
2index 0 r UNASSIGNED
3index 0 p STARTED 1 4.7kb 127.0.0.1 runTask-0
3index 0 r UNASSIGNED

Step 4 - Update setting cat.shards.limit to 2

curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.shards.response.limit.number_of_shards" : 2
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"shards":{"response":{"limit":{"number_of_shards":"2"}}}}}}%

Step 5 - Perform /_cat/shards/

curl -XGET "http://localhost:9200/_cat/shards/"

curl -XGET "http://localhost:9200/_cat/shards/"
{"error":{"root_cause":[{"type":"response_limit_breached_exception","reason":"Too many shards requested. Can not request shards beyond {2}"}],"type":"response_limit_breached_exception","reason":"Too many shards requested. Can not request shards beyond {2}"},"status":429}%

Step 6 - Update setting cat.shards.limit to 6

curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.shards.response.limit.number_of_shards" : 6
}
}'

Step 7 - Perform /_cat/shards/

curl -XGET "http://localhost:9200/_cat/shards/"
1index 0 p STARTED 1 4.7kb 127.0.0.1 runTask-0
1index 0 r UNASSIGNED
2index 0 p STARTED 1 4.7kb 127.0.0.1 runTask-0
2index 0 r UNASSIGNED
3index 0 p STARTED 1 4.7kb 127.0.0.1 runTask-0
3index 0 r UNASSIGNED

Action 2 : /_cat/indices/

Step 1 - Using cluster started in previous section

Step 2 - Perform /_cat/indices/

curl -XGET "http://localhost:9200/_cat/indices/"
yellow open 1index RdrZ-a-hQ86Dk9BkSKMceQ 1 1 1 0 4.7kb 4.7kb
yellow open 2index hb2ANDTMT7OQfMGa8dKzGA 1 1 1 0 4.7kb 4.7kb
yellow open 3index SmI1dxl2SECswo67Y37TKg 1 1 1 0 4.7kb 4.7kb

Step 3 - Update settings

curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.indices.response.limit.number_of_indices" : 1
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"indices":{"response":{"limit":{"number_of_indices":"1"}}}}}}%

Step 4 - Perform /_cat/indices/

curl -XGET "http://localhost:9200/_cat/indices/"
{"error":{"root_cause":[{"type":"response_limit_breached_exception","reason":"Too many indices requested. Can not request indices beyond {1}"}],"type":"response_limit_breached_exception","reason":"Too many indices requested. Can not request indices beyond {1}"},"status":429}%

Step 5 - Update settings
curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.indices.response.limit.number_of_indices" : -1
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"indices":{"response":{"limit":{"number_of_indices":"-1"}}}}}}%

Step 6 - Perform /_cat/indices/

curl -XGET "http://localhost:9200/_cat/indices/"
yellow open 1index RdrZ-a-hQ86Dk9BkSKMceQ 1 1 1 0 4.7kb 4.7kb
yellow open 2index hb2ANDTMT7OQfMGa8dKzGA 1 1 1 0 4.7kb 4.7kb
yellow open 3index SmI1dxl2SECswo67Y37TKg 1 1 1 0 4.7kb 4.7kb

Action 3 : /_cat/segments/

Step 1 - Using cluster started in previous section

Step 2 - Perform /_cat/segments/

curl -XGET "http://localhost:9200/_cat/segments/"
1index 0 p 127.0.0.1 _0 0 1 0 4.5kb 0 false true 9.12.0 true
2index 0 p 127.0.0.1 _0 0 1 0 4.5kb 0 false true 9.12.0 true
3index 0 p 127.0.0.1 _0 0 1 0 4.5kb 0 false true 9.12.0 true

Step3 - Update settings

curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.segments.response.limit.number_of_indices" : 1
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"segments":{"response":{"limit":{"number_of_indices":"1"}}}}}}%

Step 4 - Perform /_cat/segments/

curl -XGET "http://localhost:9200/_cat/segments/"
{"error":{"root_cause":[{"type":"response_limit_breached_exception","reason":"Segments from too many indices requested. Can not request indices beyond {1}"}],"type":"response_limit_breached_exception","reason":"Segments from too many indices requested. Can not request indices beyond {1}"},"status":429}%

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-09-18T22:23:45Z

❌ Gradle check result for 8796ab6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-18T23:05:35Z

❌ Gradle check result for 59b896a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-18T23:10:31Z

❌ Gradle check result for ec96cdd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…on dynamic limit settings Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

github-actions · 2024-09-19T12:47:31Z

❌ Gradle check result for 973f3be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-19T12:49:58Z

❌ Gradle check result for 1944512: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-19T12:51:35Z

❌ Gradle check result for 515a699: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-19T13:06:37Z

❌ Gradle check result for 27440d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sumitasr · 2024-09-19T13:12:38Z

❌ Gradle check result for 27440d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Reason - failed for task ':server:spotlessJavaCheck'.

Pushed fix post running ./gradlew :server:spotlessApply

github-actions · 2024-09-19T13:24:16Z

❌ Gradle check result for 454e2dd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

github-actions · 2024-09-19T13:46:33Z

❌ Gradle check result for 8a2140f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-19T14:11:10Z

❌ Gradle check result for 399fb59: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-19T14:51:47Z

✅ Gradle check result for 7a7ae4b: SUCCESS

codecov · 2024-09-19T14:52:14Z

Codecov Report

Attention: Patch coverage is 57.26496% with 50 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (4e3a6d0) to head (ad61a43).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...common/breaker/ResponseLimitBreachedException.java	0.00%	18 Missing ⚠️
...admin/cluster/shards/TransportCatShardsAction.java	11.11%	8 Missing ⚠️
.../opensearch/rest/action/cat/RestIndicesAction.java	30.00%	7 Missing ⚠️
...opensearch/rest/action/cat/RestSegmentsAction.java	30.00%	7 Missing ⚠️
...ensearch/common/breaker/ResponseLimitSettings.java	88.88%	3 Missing and 3 partials ⚠️
.../action/admin/cluster/shards/CatShardsRequest.java	50.00%	2 Missing ⚠️
.../opensearch/rest/action/cat/AbstractCatAction.java	0.00%	1 Missing ⚠️
...search/rest/action/list/RestIndicesListAction.java	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15986      +/-   ##
============================================
+ Coverage     71.91%   71.95%   +0.04%     
- Complexity    64491    64561      +70     
============================================
  Files          5289     5291       +2     
  Lines        301509   301620     +111     
  Branches      43557    43571      +14     
============================================
+ Hits         216818   217040     +222     
+ Misses        66892    66820      -72     
+ Partials      17799    17760      -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-30T12:58:33Z

❌ Gradle check result for ed9d8c6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/rest/action/cat/RestIndicesAction.java

server/src/main/java/org/opensearch/common/breaker/ResponseLimitSettings.java

server/src/test/java/org/opensearch/common/breaker/ResponseLimitSettingsTests.java

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

github-actions · 2024-09-30T14:42:21Z

❌ Gradle check result for 4e732b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

github-actions · 2024-10-01T06:43:48Z

❌ Gradle check result for 09492e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sumitasr · 2024-10-01T09:38:26Z

❌ Gradle check result for 09492e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Existing flaky tests are failing.

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

server/src/test/java/org/opensearch/common/breaker/ResponseLimitSettingsTests.java

github-actions · 2024-10-03T06:46:49Z

✅ Gradle check result for ad61a43: SUCCESS

shwetathareja · 2024-10-03T07:46:26Z

@sumitasr we will need documentation PR for new settings

shwetathareja · 2024-10-03T07:46:50Z

Helping with merge as it is already approved by @backslasht & @rajiv-kv

sumitasr · 2024-10-03T07:51:38Z

@sumitasr we will need documentation PR for new settings

Tracking documentation updates here opensearch-project/documentation-website#8460

opensearch-trigger-bot · 2024-10-03T08:00:10Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15986-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf6566e76c46bd7dc5d838503b8c43ff8cb09757
# Push it to GitHub
git push --set-upstream origin backport/backport-15986-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15986-to-2.x.

…on dynamic limit settings (opensearch-project#15986) * Add changes to block calls in cat shards, indices and segments based on dynamic limit settings Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

…on dynamic limit settings (#15986) (#16235) Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

…on dynamic limit settings (opensearch-project#15986) * Add changes to block calls in cat shards, indices and segments based on dynamic limit settings Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

sumitasr changed the title ~~[DRAFT] Add changes to block non-paginated calls in cat shards, indices and segments~~ [DRAFT] Add changes to block calls in cat shards, indices and segments based on dynamic limit settings Sep 18, 2024

github-actions bot added Cluster Manager enhancement Enhancement or improvement to existing feature or request labels Sep 18, 2024

sumitasr force-pushed the draft_changes_15954 branch 2 times, most recently from 59b896a to ec96cdd Compare September 18, 2024 22:36

sumitasr force-pushed the draft_changes_15954 branch 3 times, most recently from 1944512 to 515a699 Compare September 19, 2024 12:44

Add changes to block calls in cat shards, indices and segments based …

454e2dd

…on dynamic limit settings Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

sumitasr force-pushed the draft_changes_15954 branch from 515a699 to 454e2dd Compare September 19, 2024 12:45

sumitasr force-pushed the draft_changes_15954 branch from 27440d2 to 8a2140f Compare September 19, 2024 13:11

Fail fast during catShardsLimit check in cat shards action run

399fb59

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

sumitasr force-pushed the draft_changes_15954 branch from 8a2140f to 399fb59 Compare September 19, 2024 13:46

Merge remote-tracking branch 'origin/main' into draft_changes_15954

7a7ae4b

sumitasr changed the title ~~[DRAFT] Add changes to block calls in cat shards, indices and segments based on dynamic limit settings~~ Add changes to block calls in cat shards, indices and segments based on dynamic limit settings Sep 19, 2024

sumitasr marked this pull request as ready for review September 20, 2024 05:00

sumitasr requested a review from anasalkouz as a code owner September 20, 2024 05:00

gargharsh3134 approved these changes Sep 30, 2024

View reviewed changes

rajiv-kv reviewed Sep 30, 2024

View reviewed changes

Modify exception message values and add unit tests

4e732b1

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

rajiv-kv approved these changes Sep 30, 2024

View reviewed changes

Fix Forbidden annotation use: org.junit.Test

09492e1

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

opensearch-ci-bot mentioned this pull request Oct 1, 2024

[AUTOCUT] Gradle Check Flaky Test Report for SpecificClusterManagerNodesIT #15944

Open

Merge branch 'main' into draft_changes_15954

ad61a43

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

backslasht reviewed Oct 3, 2024

View reviewed changes

server/src/test/java/org/opensearch/common/breaker/ResponseLimitSettingsTests.java Show resolved Hide resolved

sumitasr mentioned this pull request Oct 3, 2024

[Paginating ClusterManager Read APIs] Blocking non-paginated calls #15954

Closed

backslasht approved these changes Oct 3, 2024

View reviewed changes

shwetathareja approved these changes Oct 3, 2024

View reviewed changes

shwetathareja added the backport 2.x Backport to 2.x branch label Oct 3, 2024

sumitasr mentioned this pull request Oct 3, 2024

[DOC] New dynamic settings introduced in OpenSearch PR #15986 opensearch-project/documentation-website#8460

Closed

4 tasks

shwetathareja merged commit bf6566e into opensearch-project:main Oct 3, 2024
36 of 46 checks passed

opensearch-trigger-bot bot added the backport-failed label Oct 3, 2024

gargharsh3134 mentioned this pull request Oct 8, 2024

Add changes to block calls in cat shards, indices and segments based … #16235

Merged

3 tasks

gbbafna pushed a commit that referenced this pull request Oct 9, 2024

Add changes to block calls in cat shards, indices and segments based …

4e5b7e5

…on dynamic limit settings (#15986) (#16235) Signed-off-by: Sumit Bansal <sumitsb@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add changes to block calls in cat shards, indices and segments based on dynamic limit settings #15986

Add changes to block calls in cat shards, indices and segments based on dynamic limit settings #15986

sumitasr commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

sumitasr commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

codecov bot commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

sumitasr commented Oct 1, 2024

github-actions bot commented Oct 3, 2024

shwetathareja commented Oct 3, 2024

shwetathareja commented Oct 3, 2024

sumitasr commented Oct 3, 2024

opensearch-trigger-bot bot commented Oct 3, 2024

Add changes to block calls in cat shards, indices and segments based on dynamic limit settings #15986

Add changes to block calls in cat shards, indices and segments based on dynamic limit settings #15986

Conversation

sumitasr commented Sep 18, 2024 • edited Loading

Description

Related Issues

Functional Testing

Action 1 : /_cat/shards/

Action 2 : /_cat/indices/

Action 3 : /_cat/segments/

Check List

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

sumitasr commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

codecov bot commented Sep 19, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

sumitasr commented Oct 1, 2024

github-actions bot commented Oct 3, 2024

shwetathareja commented Oct 3, 2024

shwetathareja commented Oct 3, 2024

sumitasr commented Oct 3, 2024

opensearch-trigger-bot bot commented Oct 3, 2024

sumitasr commented Sep 18, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading