-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add successfulSearchShardIndices in searchRequestContext #15967
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15967 +/- ##
============================================
- Coverage 71.96% 71.93% -0.04%
+ Complexity 64391 64347 -44
============================================
Files 5280 5280
Lines 300866 300871 +5
Branches 43474 43474
============================================
- Hits 216510 216420 -90
- Misses 66639 66711 +72
- Partials 17717 17740 +23 ☔ View full report in Codecov by Sentry. |
98adaf3
to
2c5ceae
Compare
❌ Gradle check result for 2c5ceae: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/action/search/AbstractSearchAsyncAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/search/SearchRequestContext.java
Outdated
Show resolved
Hide resolved
2c5ceae
to
0888e7b
Compare
❌ Gradle check result for 0888e7b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/action/search/SearchRequestContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Zane <davizane@amazon.com>
0888e7b
to
637d339
Compare
❌ Gradle check result for 637d339: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ankit Jain <akjain@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15967-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b3696116965ab45b675731af04e6defc34602f83
# Push it to GitHub
git push --set-upstream origin backport/backport-15967-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…uestEnd (opensearch-project#15967) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com> (cherry picked from commit b369611)
…uestEnd (opensearch-project#15967) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com>
…uestEnd (opensearch-project#15967) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com>
…uestEnd (opensearch-project#15967) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com>
…uestEnd (opensearch-project#15967) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com>
…uestEnd (opensearch-project#15967) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com>
Description
Add successfulSearchShardIndices in searchRequestContext
This list of indices will be used in the Query-Insights plugin for query shape generation.
Related Issues
Related RFC: opensearch-project/query-insights#69
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.