-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the capability to override indices.breaker.total.use_real_memory setting for test clusters #15906
Conversation
❌ Gradle check result for 9c63bc4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…setting for test clusters Signed-off-by: Navneet Verma <navneev@amazon.com>
❕ Gradle check result for 32d6d5c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15906 +/- ##
============================================
+ Coverage 71.90% 71.96% +0.05%
- Complexity 64216 64280 +64
============================================
Files 5272 5277 +5
Lines 300597 300691 +94
Branches 43440 43449 +9
============================================
+ Hits 216151 216378 +227
+ Misses 66680 66589 -91
+ Partials 17766 17724 -42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... Makes sense.
Do you know if there are any other important settings that differ between the Jenkins tests (or a typical production system) and the integ tests? Anything else where we might be missing out?
If we look at the baseconfig in the diff file these are the only settings which are different from jenkins because these are what set by testcluster gradle task. I didn’t find any other setting more useful. |
…setting for test clusters (opensearch-project#15906) Signed-off-by: Navneet Verma <navneev@amazon.com>
…setting for test clusters (opensearch-project#15906) Signed-off-by: Navneet Verma <navneev@amazon.com>
…setting for test clusters (opensearch-project#15906) Signed-off-by: Navneet Verma <navneev@amazon.com>
…setting for test clusters (opensearch-project#15906) Signed-off-by: Navneet Verma <navneev@amazon.com>
Description
Add the capability to override
indices.breaker.total.use_real_memory
setting for test clusters.This will allow plugins to run the integTest with heap CB enabled to ensure that their integTests runs with as close of a env which we have in Jenkins. Please read the attached issue for more details
Testing
Validated that setting can be override like this:
Related Issues
Resolves #15849
Check List
Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.