Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Support pinned timestamp in delete flow #15730

Merged

Conversation

anshu1106
Copy link
Contributor

Description

Backport for #15256

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ject#15256)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
(cherry picked from commit 5bf34d2)
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for c6317ec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 81a4408: SUCCESS

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 16.54676% with 116 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (75fb5bc) to head (8885e2b).
Report is 3 commits behind head on 2.17.

Files with missing lines Patch % Lines
...ch/repositories/blobstore/BlobStoreRepository.java 18.88% 68 Missing and 5 partials ⚠️
...ava/org/opensearch/snapshots/SnapshotsService.java 6.97% 39 Missing and 1 partial ⚠️
...n/java/org/opensearch/repositories/Repository.java 0.00% 2 Missing ⚠️
...ries/cleanup/TransportCleanupRepositoryAction.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15730      +/-   ##
============================================
- Coverage     71.66%   71.64%   -0.02%     
- Complexity    64317    64357      +40     
============================================
  Files          5262     5263       +1     
  Lines        301148   301305     +157     
  Branches      43841    43861      +20     
============================================
+ Hits         215829   215885      +56     
- Misses        67259    67298      +39     
- Partials      18060    18122      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for 8885e2b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale sachinpkale merged commit 7f08d68 into opensearch-project:2.17 Sep 5, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants