add query group stats constructs #15343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushalmahi12
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 9f34c30: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 52330cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 31f5405: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
kaushalmahi12
force-pushed
the
feature/sandbox-stats_constructs
branch
from
31f5405
to
7fada74
Compare
|
❌ Gradle check result for ce813f1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
jainankitk
reviewed
Aug 26, 2024
server/src/main/java/org/opensearch/wlm/stats/QueryGroupState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupStats.java
Outdated
Show resolved
Hide resolved
|
Also, gradle precommit is failing for this PR |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
|
❌ Gradle check result for 353b1c8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15343 +/- ##
============================================
- Coverage 71.95% 71.87% -0.09%
- Complexity 63286 63302 +16
============================================
Files 5225 5227 +2
Lines 296215 296323 +108
Branches 42788 42800 +12
============================================
- Hits 213133 212971 -162
- Misses 65559 65892 +333
+ Partials 17523 17460 -63 ☔ View full report in Codecov by Sentry. |
jainankitk
approved these changes
Aug 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
* add query group stats constructs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add packageinfo for stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add total cancellations Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more granular level rejections Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add toXContent test cases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * update the comment for query group stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> (cherry picked from commit c0bcacb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jainankitk
pushed a commit
that referenced
this pull request
Aug 28, 2024
* add query group stats constructs * add changelog entry * add packageinfo for stats * add total cancellations * add more granular level rejections * add toXContent test cases * move ResourceType enum to wlm * update the comment for query group stats --------- (cherry picked from commit c0bcacb) Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
added a commit
that referenced
this pull request
Aug 28, 2024
reta
added a commit
that referenced
this pull request
Aug 28, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
* add query group stats constructs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add packageinfo for stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add total cancellations Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more granular level rejections Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add toXContent test cases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * update the comment for query group stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
* add query group stats constructs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add packageinfo for stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add total cancellations Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more granular level rejections Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add toXContent test cases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * update the comment for query group stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
* add query group stats constructs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add packageinfo for stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add total cancellations Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more granular level rejections Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add toXContent test cases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * update the comment for query group stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
* add query group stats constructs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add packageinfo for stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add total cancellations Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more granular level rejections Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add toXContent test cases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * update the comment for query group stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces constructs to hold live view of query group level stats and point in time view of query group stats. Post these changes we will need changes to hook these constructs with various request events i,e; completions, failures, cancellations and rejections.
Related Issues
Resolves ##15120
RFC: #12342
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.