Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the class CommunityIdProcessor final #14448

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

gaobinlong
Copy link
Collaborator

Description

This is a follow-up PR for Add community_id ingest processor, the new added class CommunityIdProcessor should be final, but in the original PR we neglected that.

Other main classes of the ingest processors don't have this issue.

This PR should be backported to 2.x branch.

Related Issues

#2787

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Copy link
Contributor

✅ Gradle check result for 3a96058: SUCCESS

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.64%. Comparing base (b15cb0c) to head (b023f72).
Report is 452 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14448      +/-   ##
============================================
+ Coverage     71.42%   71.64%   +0.22%     
- Complexity    59978    62074    +2096     
============================================
  Files          4985     5118     +133     
  Lines        282275   291878    +9603     
  Branches      40946    42189    +1243     
============================================
+ Hits         201603   209109    +7506     
- Misses        63999    65511    +1512     
- Partials      16673    17258     +585     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for b3c41e8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b023f72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b023f72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for b023f72: SUCCESS

@reta reta merged commit 8aed62e into opensearch-project:main Jun 19, 2024
36 of 37 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14448-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8aed62e4c56914be1ddc802a118e7fa6039d9dc1
# Push it to GitHub
git push --set-upstream origin backport/backport-14448-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-14448-to-2.x.

@reta
Copy link
Collaborator

reta commented Jun 19, 2024

@gaobinlong could you please backport to 2.x manually? thank you

gaobinlong added a commit to gaobinlong/OpenSearch that referenced this pull request Jun 19, 2024
* Make the class CommunityIdProcessor final

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Update change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit 8aed62e)
gaobinlong added a commit to gaobinlong/OpenSearch that referenced this pull request Jun 19, 2024
* Make the class CommunityIdProcessor final

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Update change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
reta added a commit that referenced this pull request Jun 19, 2024
* Make the class CommunityIdProcessor final



* Update change log



---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
* Make the class CommunityIdProcessor final

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Update change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…pensearch-project#14453)

* Make the class CommunityIdProcessor final

* Update change log

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
* Make the class CommunityIdProcessor final

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Update change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@gaobinlong gaobinlong deleted the fix_communityid branch September 18, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants