-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Spotless and exclude Checkstyle on client module #1392
Run Spotless and exclude Checkstyle on client module #1392
Conversation
':client:rest-high-level', | ||
':client:sniffer', | ||
':client:test', | ||
':client:transport', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed client module from excluded path to run Spotless
Can one of the admins verify this patch? |
@@ -19,21 +19,13 @@ | |||
|
|||
<!-- Exclude server to run checkstyle --> | |||
<suppress files="server" checks="." /> | |||
<!-- Exclude client to run checkstyle --> | |||
<suppress files="client" checks="." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluded client module to run CheckStyle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment seems misleading. Should rather be "Excludes checkstyle run on client module" as that's what it means.
✅ Gradle Wrapper Validation success 4c99f32367219cbad813699cb8250df92d01f793 |
✅ DCO Check Passed 4c99f32367219cbad813699cb8250df92d01f793 |
✅ Gradle Precommit success 4c99f32367219cbad813699cb8250df92d01f793 |
2 similar comments
✅ Gradle Precommit success 4c99f32367219cbad813699cb8250df92d01f793 |
✅ Gradle Precommit success 4c99f32367219cbad813699cb8250df92d01f793 |
start gradle check |
✅ Gradle Check success 4c99f32367219cbad813699cb8250df92d01f793 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
I will fix the minor comment in the next coming PR. We can merge this. |
Are you okay w/ addressing the comments in the next PR @setiah? We don't want to forget; so if you want them addressed here so we don't have to carry them to the next PR let us know. I'm fine either way. |
I am running the gradle check on my local once it's done I'll push the changes. |
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
4c99f32
to
599b36f
Compare
✅ DCO Check Passed 599b36f |
✅ Gradle Wrapper Validation success 599b36f |
✅ Gradle Precommit success 599b36f |
start gradle check |
In Log 764:
|
Weird. Not able to reproduce it on my local. @tlfeng can we start the gradle check again to see if the tests are flaky over here? |
The failure might caused by multiple gradle check running simultaneously in Jenkins.. |
…ct#1392 Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi owaiskazi19@gmail.com
Description
Applied Spotless to client module and excluded it from CheckStyle.
Issues Resolved
Part of #1362 and #974
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.