Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add snapshot type information in repository data. #13826

Conversation

harishbhakuni
Copy link
Contributor

Description

  • While adding Shallow copy snapshots support, we introduced a new method deleteSnapshotsAndReleaseLockFiles (which also takes care of releasing remote store lock for the snapshot) in repository interface. We did not directly used this new method in snapshot service as it would be a breaking change for existing users who have implemented this interface differently or for those who do not have this method implemented in their repository implementation.
  • Thus, during snapshot deletion we relied on shallow_copy_snapshot_enabled repository setting flag to decide if we need to use the old method deleteSnapshots or the new method deleteSnapshotsAndReleaseLockFiles.
  • Now we will be supporting migration from remote store indices to docrep indices, we cannot rely on this repository setting as it would end up into dangling lock files in remote store.

Related Issues

Resolves #8610

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ry data.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Copy link
Contributor

❌ Gradle check result for 2ea5d6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Storage:Durability Issues and PRs related to the durability framework
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Snapshot Interop] Add Shallow Copy Snapshots list in Snapshot Repository Data
1 participant