Run Spotless and exclude CheckStyle for server module #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
changed the title
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success 245e436 |
|
✅ DCO Check Passed 245e436 |
|
✅ Gradle Precommit success 245e436 |
owaiskazi19
commented
Oct 18, 2021
| <!-- Intentionally doesn't have a package declaration to test logging | ||
| configuration of classes that aren't in packages. --> | ||
| <suppress files="test[/\\]framework[/\\]src[/\\]test[/\\]java[/\\]Dummy.java" checks="PackageDeclaration" /> | ||
|
|
||
| <!-- Intentionally has long example curl commands to coincide with sibling Painless tests. --> | ||
| <suppress files="modules[/\\]lang-painless[/\\]src[/\\]test[/\\]java[/\\]org[/\\]opensearch[/\\]painless[/\\]ContextExampleTests.java" checks="LineLength" /> | ||
|
|
||
| <!-- Exclude server to run checkstyle --> | ||
| <suppress files="server" checks="." /> |
There was a problem hiding this comment.
Excluded server module to run CheckStyle
owaiskazi19
commented
Oct 18, 2021
| @@ -121,7 +121,6 @@ def projectPathsToExclude = [ | |||
| ':plugins:transport-nio', | |||
| ':qa:die-with-dignity', | |||
| ':rest-api-spec', | |||
| ':server', | |||
There was a problem hiding this comment.
Removed server module from excluded path to run Spotless
There was a problem hiding this comment.
Nice. this definitely looks better. Tagging this comment for reviewer context.
owaiskazi19
changed the title
setiah
approved these changes
Oct 18, 2021
|
Can we start gradle check for this PR? |
|
start gradle check |
dblock
added
the
pending backport
|
We should backport this to 1.x or we risk having endless conflicts every time we backport anything after this change to 1.x. |
owaiskazi19
added a commit
to owaiskazi19/OpenSearch
that referenced
this pull request
Oct 19, 2021
…ct#1380 Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
5 tasks
nknize
pushed a commit
that referenced
this pull request
Oct 20, 2021
owaiskazi19
removed
the
pending backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Owais Kazi owaiskazi19@gmail.com
Description
Applied Spotless to server module and excluded it from CheckStyle.
Issues Resolved
Part of #1362 and #974
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.