-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13776: allow adding query parameters to RequestOptions #13777
Conversation
Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net>
❌ Gradle check result for 0a5736f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 618b4dd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
These failures are flaky tests described by, respectively, #5329 and #13600 |
Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net>
Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net>
Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net>
❌ Gradle check result for 963f929: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@gaobinlong any concerns from your side? thank you! |
Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net>
I've just fixed the |
LGTM to me! Thank you @oliverlockwood ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13777-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a32859bb5a5acc54b62df5384c7b7c949c647c2b
# Push it to GitHub
git push --set-upstream origin backport/backport-13777-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Backport #13778 |
…oject#13777) * 13776: allow adding query parameters to RequestOptions Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Fix bug highlighted by unit testing Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Address code review comments Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Run spotlessApply to satisfy formatting rules Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Fix more queryParams->parameters cases Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Apply code review feedback Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> --------- Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net>
…oject#13777) * 13776: allow adding query parameters to RequestOptions Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Fix bug highlighted by unit testing Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Address code review comments Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Run spotlessApply to satisfy formatting rules Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Fix more queryParams->parameters cases Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> * Apply code review feedback Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net> --------- Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net>
Description
Allows adding query parameters to RequestOptions, e.g. to be able to set
?filter-path=<something>
as documented in https://opensearch.org/docs/2.3/opensearch/common-parameters/#filtered-responses.Related Issues
Resolves #13776.
Check List
New functionality has been documented.API changes companion pull request created.Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.