Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jay Deng as a maintainer #13773

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

sohami
Copy link
Collaborator

@sohami sohami commented May 21, 2024

Description

Jay has accepted the invitation to become a maintainer. Welcome Jay!

Jay is an active contributor of OpenSearch project and has extensively contributed in the concurrent segment search feature to make it GA for the users. Aside from this he proactively contributed to improve the documentations for different aggregations like term, sampler, diversified sampler, etc based on his learnings and is pretty active in the triage meetings and reviewing issues/PRs. Jay has contributed 56 pull requests to the project and reviewed close to 53 PRs. Some of his main contributions are:

PRs:

Issues:

Deep Dives:
Evaluation to support force termination with terminate_after in concurrent search path #8371
Evaluation for Parent Join agg and Diversified Sampler for concurrent search support: #9316, #11075

The maintainers have voted and agreed to this nomination, following the process here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
@sohami
Copy link
Collaborator Author

sohami commented May 21, 2024

Tagging @dblock to help with the PR and permissions as mentioned here

Copy link
Contributor

❕ Gradle check result for 40d45fe: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.60%. Comparing base (b15cb0c) to head (40d45fe).
Report is 297 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13773      +/-   ##
============================================
+ Coverage     71.42%   71.60%   +0.18%     
- Complexity    59978    61231    +1253     
============================================
  Files          4985     5062      +77     
  Lines        282275   287905    +5630     
  Branches      40946    41692     +746     
============================================
+ Hits         201603   206155    +4552     
- Misses        63999    64691     +692     
- Partials      16673    17059     +386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sohami
Copy link
Collaborator Author

sohami commented May 21, 2024

❕ Gradle check result for 40d45fe: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Known issue: #10983

@owaiskazi19
Copy link
Member

Tagging @dblock to help with the PR and permissions as mentioned here

@opensearch-project/admin

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well deserved @jed326 !

@sohami
Copy link
Collaborator Author

sohami commented May 22, 2024

Tagging @dblock to help with the PR and permissions as mentioned here

@opensearch-project/admin

Will wait for the @opensearch-project/admin team confirmation about permissions before merging this PR.

@rishabh6788
Copy link
Contributor

Added @jed326 as maintainer.

@sohami sohami merged commit 199a03e into opensearch-project:main May 22, 2024
77 of 78 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 22, 2024
Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
(cherry picked from commit 199a03e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sohami pushed a commit that referenced this pull request May 22, 2024
(cherry picked from commit 199a03e)

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…roject#13774)

(cherry picked from commit 199a03e)

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants