-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support to inject telemetry instances to plugins #13636
Adds support to inject telemetry instances to plugins #13636
Conversation
❌ Gradle check result for d30fca6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b18e370: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13636 +/- ##
============================================
+ Coverage 71.42% 71.57% +0.14%
- Complexity 59978 61124 +1146
============================================
Files 4985 5053 +68
Lines 282275 287158 +4883
Branches 40946 41607 +661
============================================
+ Hits 201603 205520 +3917
- Misses 63999 64647 +648
- Partials 16673 16991 +318 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for 46a2319: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@Gaganjuneja please rebase against main, thank you |
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
46a2319
to
f58cd00
Compare
❌ Gradle check result for f58cd00: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for f58cd00: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
* Adds support to inject telemetry instances to plugins Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * incorporate pr comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit 6ba6f59) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adds support to inject telemetry instances to plugins * Adds test * incorporate pr comments --------- (cherry picked from commit 6ba6f59) Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…ject#13636) * Adds support to inject telemetry instances to plugins Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * incorporate pr comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…ject#13636) * Adds support to inject telemetry instances to plugins Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * incorporate pr comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Description
This change will make available the telemetry instances such as tracer and metrics registry to all the plugins.
Related Issues
Resolves #13635
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.