-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor remote store flow to support any path type #12822
Refactor remote store flow to support any path type #12822
Conversation
Compatibility status:Checks if related components are compatible with change d9e12db Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 29c3266: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
29c3266
to
21636af
Compare
❕ Gradle check result for 21636af: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Flaky test - #12197 |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
21636af
to
e21ec8f
Compare
Signed-off-by: Ashish Singh <ssashish@amazon.com>
…tion Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
b73200b
to
08448a5
Compare
❌ Gradle check result for aefc1ae: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 49941fd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 08448a5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b73200b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
❕ Gradle check result for d9e12db: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
…ct#12822) Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ct#12822) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 3907ec9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Auto backport failed, raising manual backport. |
…ct#12822) Signed-off-by: Ashish Singh <ssashish@amazon.com>
…2822 #12920 (#13405) * Refactor remote store flow to support any path type (#12822) Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add missed API visibility annotations for public APIs (#12920) Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ct#12822) Signed-off-by: Ashish Singh <ssashish@amazon.com>
Description
This PR is a sub task of feature request #12567 and being tracked in meta issue - #12589.
In the prior PR #12607 & #12753, we have introduced remote store path type in the customData field in IndexMetadata and handled association of path types of indexes during snapshot restore. In this PR, we are refactoring existing remote store flows to add support for using any remote store path type with backward compatibility.
In brief, we are doing follow things -
Related Issues
Resolves #12790
Check List
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.