Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename translog pruning setting to CCR specific setting and addressed Bug in the test case #1243

Merged
merged 7 commits into from
Sep 24, 2021
Merged

Rename translog pruning setting to CCR specific setting and addressed Bug in the test case #1243

merged 7 commits into from
Sep 24, 2021

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Sep 15, 2021 •
edited
Loading

Description

  • Rename translog pruning setting to CCR specific setting
    • From index.translog.retention_lease.pruning.enabled to index.plugins.replication.translog.retention_lease.pruning.enabled
  • [Bug] Fix test case issue for translog deletion policy and translog tests

Issues Resolved

#1100

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed c98a94e0424aaf62b88f0431e7e4a59473b2b5ea

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success c98a94e0424aaf62b88f0431e7e4a59473b2b5ea

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success c98a94e0424aaf62b88f0431e7e4a59473b2b5ea

@saikaranam-amazon saikaranam-amazon changed the title Rename translog pruning setting to CCR specific setting Rename translog pruning setting to CCR specific setting and Addressed Bug in the test case Sep 15, 2021
@saikaranam-amazon saikaranam-amazon changed the title Rename translog pruning setting to CCR specific setting and Addressed Bug in the test case Rename translog pruning setting to CCR specific setting and addressed Bug in the test case Sep 15, 2021
@nknize
Copy link
Collaborator

nknize commented Sep 16, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c98a94e0424aaf62b88f0431e7e4a59473b2b5ea
Log 532

Reports 532

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 71e1b1db9e94d4104872dbb6add9356f08d8238c

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 71e1b1db9e94d4104872dbb6add9356f08d8238c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 71e1b1db9e94d4104872dbb6add9356f08d8238c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 9e9eedf187b7084c21b3bf1ced91b896a83702a7

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 9e9eedf187b7084c21b3bf1ced91b896a83702a7

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 9e9eedf187b7084c21b3bf1ced91b896a83702a7

@itiyamas
Copy link
Contributor

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9e9eedf187b7084c21b3bf1ced91b896a83702a7
Log 537

Reports 537

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed bf29d69c398686940b23acfcdbcfd02f6038fc98

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success bf29d69c398686940b23acfcdbcfd02f6038fc98

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success bf29d69c398686940b23acfcdbcfd02f6038fc98

@saikaranam-amazon
Copy link
Member Author

saikaranam-amazon commented Sep 17, 2021 •
edited
Loading

1.x branch is generating 1.2 artifacts and build is expecting 1.1 artifacts

Building 1.1.0 didn't generate expected file /Volumes/Unix/OpenSearch/OpenSearch/distribution/bwc/minor/build/bwc/checkout-1.x/distribution/archives/linux-tar/build/distributions/opensearch-1.1.0-SNAPSHOT-linux-x64.tar.gz

Actual file generated - opensearch-1.2.0-SNAPSHOT-linux-x64.tar.gz

@CEHENKLE
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success bf29d69c398686940b23acfcdbcfd02f6038fc98
Log 538

Reports 538

@saikaranam-amazon saikaranam-amazon force-pushed the os-rename-setting branch 2 times, most recently from 5369642 to 69c4d27 Compare September 22, 2021 15:34
@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed 5369642c4d5d4c934a7e696de0d23cc554a01d14
Run ./dev-tools/signoff-check.sh remotes/origin/main 5369642c4d5d4c934a7e696de0d23cc554a01d14 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 69c4d27756f21e510a789f2d990ca6358b83b304

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 69c4d27756f21e510a789f2d990ca6358b83b304

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 69c4d27756f21e510a789f2d990ca6358b83b304

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success b413418f73845085ee7bb70b81a4e2f851950ad1

@nknize nknize self-requested a review September 23, 2021 17:26
nknize
nknize approved these changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b413418f73845085ee7bb70b81a4e2f851950ad1
Log 562

Reports 562

@nknize
Copy link
Collaborator

nknize commented Sep 23, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b413418f73845085ee7bb70b81a4e2f851950ad1
Log 563

Reports 563

@nknize
Copy link
Collaborator

nknize commented Sep 23, 2021

The build was broke by #1251 where min was added to the artifact and bwc tests are still expecting a file w/o the min label.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 34a08a1c783863e5101ae47b650e955816a098ba

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 34a08a1c783863e5101ae47b650e955816a098ba

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 34a08a1c783863e5101ae47b650e955816a098ba

@saikaranam-amazon @nknize
Rename translog pruing setting to CCR specific setting
be30bba 
Signed-off-by: Sai Kumar <karanas@amazon.com>
@saikaranam-amazon @nknize
Rename to index.plugins.replication.translog.retention_lease.pruning.…
94ed648 
…enabled as

index settings needs "index." as prefix

Signed-off-by: Sai Kumar <karanas@amazon.com>
@nknize
Add deprecations to retention pruning controls
d91da8c 
This commit adds deprecation flags to all added settings, variables, and methods
specific to ccr's retention lease pruning mechanism.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@saikaranam-amazon @nknize
Addressed CR comments
0da391d 
Signed-off-by: Sai Kumar <karanas@amazon.com>
@nknize
fix javadoc deprecation
004f8d9 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
fix deprecation tag in TranslogDeletionPolicy
1f603ca 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@saikaranam-amazon @nknize
Addressed test issue under translog tests
aea0ba8 
Signed-off-by: Sai Kumar <karanas@amazon.com>
@nknize
Copy link
Collaborator

nknize commented Sep 24, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success aea0ba8

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed aea0ba8

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success aea0ba8

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure aea0ba8
Log 567

Reports 567

@nknize
Copy link
Collaborator

nknize commented Sep 24, 2021

unrelated test failure. I opened an issue Kicking off gradle check again (this is really bad practice; we need better random testing to catch these failures quicker).

@nknize
Copy link
Collaborator

nknize commented Sep 24, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success aea0ba8
Log 568

Reports 568

@CEHENKLE CEHENKLE merged commit 29c88c6 into opensearch-project:main Sep 24, 2021
@nknize nknize mentioned this pull request Sep 28, 2021
Closed
@nknize nknize mentioned this pull request Apr 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saikaranam-amazon @opensearch-ci-bot @nknize @itiyamas @CEHENKLE