-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable test CardinalityWithRequestBreakerIT.testRequestBreaker after lucene 99 upgrade #11841
Enable test CardinalityWithRequestBreakerIT.testRequestBreaker after lucene 99 upgrade #11841
Conversation
…lucene 99 upgrade Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Compatibility status:Checks if related components are compatible with change 46e3313 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 46e3313: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 46e3313: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11841 +/- ##
============================================
+ Coverage 71.36% 71.37% +0.01%
- Complexity 59304 59326 +22
============================================
Files 4919 4919
Lines 278912 278912
Branches 40543 40543
============================================
+ Hits 199052 199083 +31
+ Misses 63337 63263 -74
- Partials 16523 16566 +43 ☔ View full report in Codecov by Sentry. |
10be2ef
into
opensearch-project:main
@neetikasinghal Do you want to backport it to |
@kotwanikunal thanks for merging, yes I have just added the label for it. |
…lucene 99 upgrade (opensearch-project#11841) Signed-off-by: Neetika Singhal <neetiks@amazon.com>
…lucene 99 upgrade (opensearch-project#11841) Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Enabling the test as the memory leak wouldn't happen after lucene 99 upgrade as explained here
Validated that the required lucene change is present and ran the test with relevant seed for 500 times to ensure successful runs.
Related Issues
Resolves #10154
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.