Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexRandomForConcurrentSearch to tests #11259

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Nov 17, 2023

Add indexRandomForConcurrentSearch to tests:

  • CardinalityWithRequestBreakerIT.java
  • TopHitsIT.java
  • SearchFieldsIT.java
  • DecayFunctionScoreIT.java
  • FunctionScoreFieldValueIT.java
  • FunctionScoreIT.java
  • FunctionScorePluginIT.java
  • QueryRescorerIT.java

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>
@jed326 jed326 changed the title Add indexRandomForConcurrentSearch Add indexRandomForConcurrentSearch to tests Nov 17, 2023
Copy link
Contributor

github-actions bot commented Nov 17, 2023

Compatibility status:

Checks if related components are compatible with change 27cb5cd

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

✅ Gradle check result for 81e801e: SUCCESS

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37ec313) 71.32% compared to head (27cb5cd) 71.33%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11259      +/-   ##
============================================
+ Coverage     71.32%   71.33%   +0.01%     
+ Complexity    58980    58978       -2     
============================================
  Files          4890     4890              
  Lines        277396   277396              
  Branches      40301    40301              
============================================
+ Hits         197842   197875      +33     
- Misses        63112    63117       +5     
+ Partials      16442    16404      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* CardinalityWithRequestBreakerIT.java
* TopHitsIT.java
* SearchFieldsIT.java
* DecayFunctionScoreIT.java
* FunctionScoreFieldValueIT.java
* FunctionScoreIT.java
* FunctionScorePluginIT.java
* QueryRescorerIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Copy link
Contributor

❕ Gradle check result for 27cb5cd: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sohami
Copy link
Collaborator

sohami commented Nov 19, 2023

❕ Gradle check result for 27cb5cd: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Existing issue: #3603

@sohami sohami merged commit edbc4e2 into opensearch-project:main Nov 19, 2023
29 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 19, 2023
* Update Concurrent search related tests to use slice count > 1.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>

* Add indexRandomForConcurrentSearch to tests:
* CardinalityWithRequestBreakerIT.java
* TopHitsIT.java
* SearchFieldsIT.java
* DecayFunctionScoreIT.java
* FunctionScoreFieldValueIT.java
* FunctionScoreIT.java
* FunctionScorePluginIT.java
* QueryRescorerIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>

---------

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
(cherry picked from commit edbc4e2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sohami pushed a commit that referenced this pull request Nov 20, 2023
* Update Concurrent search related tests to use slice count > 1.




* Add indexRandomForConcurrentSearch to tests:
* CardinalityWithRequestBreakerIT.java
* TopHitsIT.java
* SearchFieldsIT.java
* DecayFunctionScoreIT.java
* FunctionScoreFieldValueIT.java
* FunctionScoreIT.java
* FunctionScorePluginIT.java
* QueryRescorerIT.java



---------




(cherry picked from commit edbc4e2)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
* Update Concurrent search related tests to use slice count > 1.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>

* Add indexRandomForConcurrentSearch to tests:
* CardinalityWithRequestBreakerIT.java
* TopHitsIT.java
* SearchFieldsIT.java
* DecayFunctionScoreIT.java
* FunctionScoreFieldValueIT.java
* FunctionScoreIT.java
* FunctionScorePluginIT.java
* QueryRescorerIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>

---------

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
@jed326 jed326 deleted the slices-final branch March 12, 2024 22:13
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
* Update Concurrent search related tests to use slice count > 1.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>

* Add indexRandomForConcurrentSearch to tests:
* CardinalityWithRequestBreakerIT.java
* TopHitsIT.java
* SearchFieldsIT.java
* DecayFunctionScoreIT.java
* FunctionScoreFieldValueIT.java
* FunctionScoreIT.java
* FunctionScorePluginIT.java
* QueryRescorerIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>

---------

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Update Concurrent search related tests to use slice count > 1.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>

* Add indexRandomForConcurrentSearch to tests:
* CardinalityWithRequestBreakerIT.java
* TopHitsIT.java
* SearchFieldsIT.java
* DecayFunctionScoreIT.java
* FunctionScoreFieldValueIT.java
* FunctionScoreIT.java
* FunctionScorePluginIT.java
* QueryRescorerIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>

---------

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants