-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing concurrent search tests with one slice #11071
Conversation
Gradle Check (Jenkins) Run Completed with:
|
@neetikasinghal and @sohami please review. |
6d92877
to
1dfb248
Compare
Signed-off-by: Ticheng Lin <ticheng@amazon.com>
1dfb248
to
3ce73bf
Compare
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 08d57b6 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #11071 +/- ##
============================================
- Coverage 71.29% 71.25% -0.04%
- Complexity 58742 58764 +22
============================================
Files 4872 4872
Lines 276777 276780 +3
Branches 40240 40241 +1
============================================
- Hits 197316 197219 -97
- Misses 62943 63094 +151
+ Partials 16518 16467 -51
|
Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Signed-off-by: Ticheng Lin <ticheng@amazon.com>
08d57b6
to
f09a93a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
* Fixing concurrent search tests with one slice (#11071) Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Remove changes for non-flaky tests (#11071) Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> (cherry picked from commit 747f7d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fixing concurrent search tests with one slice (#11071) * Remove changes for non-flaky tests (#11071) --------- (cherry picked from commit 747f7d1) Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fixing concurrent search tests with one slice (opensearch-project#11071) Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Remove changes for non-flaky tests (opensearch-project#11071) Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com>
* Fixing concurrent search tests with one slice (opensearch-project#11071) Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Remove changes for non-flaky tests (opensearch-project#11071) Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This PR is to make sure that the index random function which is used in multiple classes has creation of multiple segments to test the concurrent search code path in the following IT:
This change will fix 31 concurrent search tests.
Related Issues
#10247
Concurrent search case muted pending fix:
#11065
Check List
New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.