Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing concurrent search tests with one slice #11071

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

ticheng-aws
Copy link
Contributor

@ticheng-aws ticheng-aws commented Nov 2, 2023

Description

This PR is to make sure that the index random function which is used in multiple classes has creation of multiple segments to test the concurrent search code path in the following IT:

SimpleNestedIT
PitMultiNodeIT
QueryStringIT
ScriptScoreQueryIT

This change will fix 31 concurrent search tests.

Related Issues

#10247
Concurrent search case muted pending fix:
#11065

Check List

  • New functionality includes testing.
  • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

@ticheng-aws
Copy link
Contributor Author

@neetikasinghal and @sohami please review.

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Compatibility status:

Checks if related components are compatible with change 08d57b6

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #11071 (f09a93a) into main (63aff16) will decrease coverage by 0.04%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main   #11071      +/-   ##
============================================
- Coverage     71.29%   71.25%   -0.04%     
- Complexity    58742    58764      +22     
============================================
  Files          4872     4872              
  Lines        276777   276780       +3     
  Branches      40240    40241       +1     
============================================
- Hits         197316   197219      -97     
- Misses        62943    63094     +151     
+ Partials      16518    16467      -51     
Files Coverage Δ
...s/replication/SegmentReplicationTargetService.java 56.17% <100.00%> (+0.56%) ⬆️

... and 482 files with indirect coverage changes

ticheng-aws added a commit to ticheng-aws/OpenSearch that referenced this pull request Nov 3, 2023
Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 5, 2023

Gradle Check (Jenkins) Run Completed with:

@sohami sohami merged commit 747f7d1 into opensearch-project:main Nov 5, 2023
35 checks passed
@ticheng-aws ticheng-aws added the backport 2.x Backport to 2.x branch label Nov 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 6, 2023
* Fixing concurrent search tests with one slice (#11071)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>

* Remove changes for non-flaky tests (#11071)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>

---------

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
(cherry picked from commit 747f7d1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Nov 8, 2023
* Fixing concurrent search tests with one slice (#11071)



* Remove changes for non-flaky tests (#11071)



---------


(cherry picked from commit 747f7d1)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
* Fixing concurrent search tests with one slice (opensearch-project#11071)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>

* Remove changes for non-flaky tests (opensearch-project#11071)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>

---------

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Fixing concurrent search tests with one slice (opensearch-project#11071)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>

* Remove changes for non-flaky tests (opensearch-project#11071)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>

---------

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants