Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test testSendCorruptBytesToReplica #10897

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Oct 24, 2023

Description

This test is failing with WindowsFS.
This change moves SegRep corruption tests to a separate IT class and skips running on WindowsFS.

Related Issues

Resolves #10542
Resolves #10709

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. bug Something isn't working flaky-test Random test failure that succeeds on second run Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Oct 24, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Oct 24, 2023

Gradle Check (Jenkins) Run Completed with:

#10899 again

@mch2 mch2 added the backport 2.x Backport to 2.x branch label Oct 24, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Oct 24, 2023

Gradle Check (Jenkins) Run Completed with:

#10885

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Oct 25, 2023

Gradle Check (Jenkins) Run Completed with:

#10902

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Oct 25, 2023

#10902

#10902

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Oct 25, 2023

Gradle Check (Jenkins) Run Completed with:

#10903

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Oct 25, 2023

Gradle Check (Jenkins) Run Completed with:

....another one #10899

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

This test is failing with WindowsFS.
This change moves SegRep corruption tests to a separate IT class and skips running on WindowsFS.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #10897 (f155d9c) into main (5a288ed) will decrease coverage by 0.01%.
Report is 8 commits behind head on main.
The diff coverage is 72.93%.

@@             Coverage Diff              @@
##               main   #10897      +/-   ##
============================================
- Coverage     71.22%   71.21%   -0.01%     
- Complexity    58678    58701      +23     
============================================
  Files          4869     4872       +3     
  Lines        276496   276682     +186     
  Branches      40203    40219      +16     
============================================
+ Hits         196936   197044     +108     
- Misses        63114    63202      +88     
+ Partials      16446    16436      -10     
Files Coverage Δ
...search/repositories/s3/AmazonAsyncS3Reference.java 84.61% <100.00%> (+1.28%) ⬆️
.../repositories/s3/AmazonAsyncS3WithCredentials.java 100.00% <100.00%> (ø)
...org/opensearch/repositories/s3/S3AsyncService.java 72.28% <100.00%> (+1.09%) ⬆️
...va/org/opensearch/repositories/s3/S3BlobStore.java 68.75% <100.00%> (+0.49%) ⬆️
...a/org/opensearch/repositories/s3/S3Repository.java 70.08% <100.00%> (+0.25%) ⬆️
...search/cluster/coordination/CoordinationState.java 88.39% <ø> (ø)
.../org/opensearch/cluster/service/MasterService.java 84.51% <100.00%> (-0.56%) ⬇️
...h/common/blobstore/stream/write/WritePriority.java 100.00% <100.00%> (ø)
...nsearch/gateway/remote/RemotePersistenceStats.java 100.00% <100.00%> (ø)
...epositories/blobstore/ChecksumBlobStoreFormat.java 95.45% <100.00%> (+0.29%) ⬆️
... and 12 more

... and 469 files with indirect coverage changes

@mch2 mch2 merged commit 6779633 into opensearch-project:main Oct 25, 2023
17 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2023
(cherry picked from commit 6779633)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mch2 mch2 deleted the corruptflaky branch October 25, 2023 18:47
mch2 pushed a commit that referenced this pull request Oct 25, 2023
(cherry picked from commit 6779633)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2 pushed a commit that referenced this pull request Oct 26, 2023
(cherry picked from commit 6779633)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run Indexing:Replication Issues and PRs related to core replication framework eg segrep skip-changelog >test-failure Test failure from CI, local build, etc.
Projects
None yet
3 participants