-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test testSendCorruptBytesToReplica #10897
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mch2
requested review from
abbashus,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
msfroh,
nknize,
owaiskazi19,
peternied,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami and
VachaShah
as code owners
October 24, 2023 21:34
github-actions
bot
added
>test-failure
Test failure from CI, local build, etc.
bug
Something isn't working
flaky-test
Random test failure that succeeds on second run
Indexing:Replication
Issues and PRs related to core replication framework eg segrep
labels
Oct 24, 2023
Gradle Check (Jenkins) Run Completed with:
|
#10899 again |
Gradle Check (Jenkins) Run Completed with:
|
|
kkmr
approved these changes
Oct 25, 2023
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
....another one #10899 |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Rishikesh1159
approved these changes
Oct 25, 2023
Gradle Check (Jenkins) Run Completed with:
|
This test is failing with WindowsFS. This change moves SegRep corruption tests to a separate IT class and skips running on WindowsFS. Signed-off-by: Marc Handalian <handalm@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10897 +/- ##
============================================
- Coverage 71.22% 71.21% -0.01%
- Complexity 58678 58701 +23
============================================
Files 4869 4872 +3
Lines 276496 276682 +186
Branches 40203 40219 +16
============================================
+ Hits 196936 197044 +108
- Misses 63114 63202 +88
+ Partials 16446 16436 -10
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 6779633) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
pushed a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 6779633) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
pushed a commit
that referenced
this pull request
Oct 26, 2023
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
bug
Something isn't working
flaky-test
Random test failure that succeeds on second run
Indexing:Replication
Issues and PRs related to core replication framework eg segrep
skip-changelog
>test-failure
Test failure from CI, local build, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test is failing with WindowsFS.
This change moves SegRep corruption tests to a separate IT class and skips running on WindowsFS.
Related Issues
Resolves #10542
Resolves #10709
Check List
New functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.