Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute CardinalityWithRequestBreakerIT pending fix #10752

Conversation

andrross
Copy link
Member

@andrross andrross commented Oct 19, 2023

Relates #10154

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Compatibility status:

Checks if related components are compatible with change c5ea28b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@sohami
Copy link
Collaborator

sohami commented Oct 19, 2023

Was just looking into this to mute for now. Thanks for taking this up. I do see lots of other yaml test failure in gradle check output.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member Author

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sohami
Copy link
Collaborator

sohami commented Oct 20, 2023

https://build.ci.opensearch.org/job/gradle-check/28539/

#10799

Just curious were previous failures due to some missing rebase ?

@andrross andrross force-pushed the mute-CardinalityWithRequestBreakerIT branch from 85103f9 to 3afd3af Compare October 21, 2023 00:25
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Relates opensearch-project#10154

Signed-off-by: Andrew Ross <andrross@amazon.com>
Copy link
Contributor

✅ Gradle check result for c5ea28b: SUCCESS

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #10752 (c5ea28b) into main (0d54c16) will decrease coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10752      +/-   ##
============================================
- Coverage     71.19%   71.13%   -0.06%     
+ Complexity    58816    58758      -58     
============================================
  Files          4883     4883              
  Lines        277144   277144              
  Branches      40281    40281              
============================================
- Hits         197310   197149     -161     
- Misses        63425    63503      +78     
- Partials      16409    16492      +83     

see 456 files with indirect coverage changes

@andrross andrross merged commit c676479 into opensearch-project:main Nov 13, 2023
35 of 38 checks passed
@andrross andrross deleted the mute-CardinalityWithRequestBreakerIT branch November 13, 2023 16:53
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2023
Relates #10154

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit c676479)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sohami pushed a commit that referenced this pull request Nov 20, 2023
Relates #10154


(cherry picked from commit c676479)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…10752)

Relates opensearch-project#10154

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants