Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @abbashus and @adnapibar back to CODEOWNERS #10681

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Oct 18, 2023

Then I copy/pasted the sorted list back into the file.

Description

Add @abbashus and @adnapibar back to CODEOWNERS, since they are in MAINTAINERS.

Also, I sorted CODEOWNERS alphabetically, with:

  cat CODEOWNERS | tr ' ' '\n' | sort

Then I copy/pasted the sorted list back into the file.

Related Issues

Resolves #9534

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Also, I sorted CODEOWNERS alphabetically, with:
  cat CODEOWNERS | tr ' ' '\n' | sort

Then I copy/pasted the sorted list back into the file.

Signed-off-by: Michael Froh <froh@amazon.com>
@github-actions github-actions bot added the bug Something isn't working label Oct 18, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 2e8a3f3

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #10681 (2e8a3f3) into main (7b62e2f) will decrease coverage by 0.07%.
Report is 3 commits behind head on main.
The diff coverage is 75.51%.

@@             Coverage Diff              @@
##               main   #10681      +/-   ##
============================================
- Coverage     71.26%   71.20%   -0.07%     
+ Complexity    58561    58498      -63     
============================================
  Files          4853     4853              
  Lines        275764   275791      +27     
  Branches      40135    40138       +3     
============================================
- Hits         196535   196376     -159     
- Misses        62800    63002     +202     
+ Partials      16429    16413      -16     
Files Coverage Δ
...rg/opensearch/telemetry/tracing/DefaultTracer.java 100.00% <100.00%> (ø)
.../opensearch/telemetry/tracing/noop/NoopTracer.java 87.50% <100.00%> (+1.78%) ⬆️
...search/telemetry/metrics/OTelMetricsTelemetry.java 100.00% <100.00%> (ø)
...rg/opensearch/telemetry/tracing/OTelTelemetry.java 100.00% <100.00%> (ø)
...search/telemetry/tracing/OTelTracingTelemetry.java 95.83% <100.00%> (+0.37%) ⬆️
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <100.00%> (ø)
...va/org/opensearch/telemetry/TelemetrySettings.java 90.90% <100.00%> (+3.40%) ⬆️
...rg/opensearch/telemetry/tracing/WrappedTracer.java 78.57% <100.00%> (+1.64%) ⬆️
...lemetry/tracing/channels/TraceableHttpChannel.java 54.54% <100.00%> (ø)
...lemetry/tracing/channels/TraceableRestChannel.java 84.21% <100.00%> (ø)
... and 5 more

... and 474 files with indirect coverage changes

@msfroh msfroh requested a review from sohami as a code owner October 18, 2023 07:24
@peternied peternied merged commit a3c1d50 into opensearch-project:main Oct 19, 2023
68 of 69 checks passed
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
@dblock
Copy link
Member

dblock commented Oct 24, 2023

Seems like that's not correct.

Screenshot 2023-10-24 at 12 31 08 PM

shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…0681)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] maintainers missing in codeowners
3 participants