Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Heap after GC stats #981

Closed
Bukhtawar opened this issue Jul 18, 2021 · 9 comments
Closed

Support for Heap after GC stats #981

Bukhtawar opened this issue Jul 18, 2021 · 9 comments
Labels
enhancement Enhancement or improvement to existing feature or request v1.2.0 Issues related to version 1.2.0 v2.0.0 Version 2.0.0

Comments

@Bukhtawar
Copy link
Collaborator

JVM stats published today represents the point in time usage of the heap across pools. While
MemoryPoolMXBean#getCollectionUsage based on docs

"Returns the memory usage after the Java virtual machine most recently expended effort in recycling unused objects in this memory pool"

provides a better indicator of GC throughput. This would typically be of interest for Old gen. If the collection usage increases it most likely indicates some trouble.

@Bukhtawar Bukhtawar added the enhancement Enhancement or improvement to existing feature or request label Jul 18, 2021
@reta
Copy link
Collaborator

reta commented Sep 10, 2021

@Bukhtawar would you mind if I will take this one? thank you!

@Bukhtawar
Copy link
Collaborator Author

@reta sure please go ahead. Thanks for contributing

@reta
Copy link
Collaborator

reta commented Sep 28, 2021

Thanks a lot @dblock for merging the change, may I ask you please to add 2.0 label and close this one? Thank you!

@dblock
Copy link
Member

dblock commented Sep 28, 2021

If we want this in 1.2 you can backport it to 1.x, too.

@dblock dblock added the v2.0.0 Version 2.0.0 label Sep 28, 2021
@dblock dblock closed this as completed Sep 28, 2021
@reta
Copy link
Collaborator

reta commented Sep 28, 2021

If we want this in 1.2 you can backport it to 1.x, too.

👍, that would be great, I would need to lower the version requirement to 1.2.0 and backport this small change back to main, if you have no objections, will do that tomorrow :-) thank you!

@dblock
Copy link
Member

dblock commented Sep 28, 2021

No objections from me. You can generally backport small features as long as no backwards compatibility is broken.

@reta
Copy link
Collaborator

reta commented Sep 28, 2021

Thanks @dblock! The PR is out, nay I ask you please, if the official documentation has to be manually updated (since this is user-facing API) or it is automatically generated? I had troubles to find the details, thank you!

@dblock
Copy link
Member

dblock commented Sep 29, 2021

I am not sure re: documentation, if it's javadoc then it's automatic, otherwise it goes manually to https://github.com/opensearch-project/documentation-website

@reta
Copy link
Collaborator

reta commented Sep 30, 2021

@dblock thank you, may I ask you please to add 1.2.0 label to the issue as well, back ported, thank you!

@dblock dblock added the v1.2.0 Issues related to version 1.2.0 label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request v1.2.0 Issues related to version 1.2.0 v2.0.0 Version 2.0.0
Projects
None yet
Development

No branches or pull requests

3 participants