-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Heap after GC stats #981
Comments
@Bukhtawar would you mind if I will take this one? thank you! |
@reta sure please go ahead. Thanks for contributing |
Thanks a lot @dblock for merging the change, may I ask you please to add 2.0 label and close this one? Thank you! |
If we want this in 1.2 you can backport it to 1.x, too. |
👍, that would be great, I would need to lower the version requirement to 1.2.0 and backport this small change back to |
No objections from me. You can generally backport small features as long as no backwards compatibility is broken. |
Thanks @dblock! The PR is out, nay I ask you please, if the official documentation has to be manually updated (since this is user-facing API) or it is automatically generated? I had troubles to find the details, thank you! |
I am not sure re: documentation, if it's javadoc then it's automatic, otherwise it goes manually to https://github.com/opensearch-project/documentation-website |
@dblock thank you, may I ask you please to add |
JVM stats published today represents the point in time usage of the heap across pools. While
MemoryPoolMXBean#getCollectionUsage based on docs
"Returns the memory usage after the Java virtual machine most recently expended effort in recycling unused objects in this memory pool"
provides a better indicator of GC throughput. This would typically be of interest for Old gen. If the collection usage increases it most likely indicates some trouble.
The text was updated successfully, but these errors were encountered: