Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide access to new settings for HyphenationCompoundWordTokenFilter #8796

Closed
MartinDemberger opened this issue Jul 20, 2023 · 7 comments · Fixed by #13895
Closed

Provide access to new settings for HyphenationCompoundWordTokenFilter #8796

MartinDemberger opened this issue Jul 20, 2023 · 7 comments · Fixed by #13895
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers low hanging fruit Search:Relevance Search Search query, autocomplete ...etc

Comments

@MartinDemberger
Copy link

Is your feature request related to a problem? Please describe.
In Lucene two additional settings for HyphenationCompoundWordTokenFilter are added. They should be available in opensearch

Describe the solution you'd like
The new parameters should be supported.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
See apache/lucene#9231 which adds the settings.

@MartinDemberger MartinDemberger added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 20, 2023
@Xtansia Xtansia added the Indexing Indexing, Bulk Indexing and anything related to indexing label Aug 13, 2023
@anasalkouz anasalkouz added the Search Search query, autocomplete ...etc label Aug 22, 2023
@anasalkouz anasalkouz removed the Indexing Indexing, Bulk Indexing and anything related to indexing label Aug 22, 2023
@msfroh msfroh moved this from 🆕 New to Now(This Quarter) in Search Project Board Aug 23, 2023
@msfroh msfroh added good first issue Good for newcomers low hanging fruit and removed untriaged labels Aug 23, 2023
@macohen
Copy link
Contributor

macohen commented Oct 19, 2023

@evankielley are you working on this? I want to assign to you (I see the PR), but I can't until you have participated in the issue itself. thanks.

@macohen macohen moved this from Now(This Quarter) to 🏗 In progress in Search Project Board Oct 19, 2023
@evankielley
Copy link
Contributor

Hey, yes, sorry, I dropped off a bit while on vacation. You can assign this to me, I think I just need to rebase and get my PR re-reviewed

@msfroh
Copy link
Collaborator

msfroh commented May 1, 2024

@hasnain2808, you expressed some interest in working on this, right?

@hasnain2808
Copy link
Contributor

Hey
Could you please assign this to me!

@msfroh msfroh assigned hasnain2808 and unassigned evankielley May 1, 2024
@getsaurabh02
Copy link
Member

We discussed this in the Search community meeting today. @hasnain2808 we hope you are still interested in this.

@hasnain2808
Copy link
Contributor

hasnain2808 commented May 24, 2024

@getsaurabh02
I will get to this asap!
Is there some deadline for this?

@getsaurabh02
Copy link
Member

Thanks, @hasnain2808, for opening the PR. There's no strict deadline for this issue, so we can address it once changes are ready at your end.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Search Project Board Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment