Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Translog] Metadata file naming and its clean up #5677

Closed
gbbafna opened this issue Jan 2, 2023 · 1 comment
Closed

[Remote Translog] Metadata file naming and its clean up #5677

gbbafna opened this issue Jan 2, 2023 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework

Comments

@gbbafna
Copy link
Collaborator

gbbafna commented Jan 2, 2023

Is your feature request related to a problem? Please describe.

Currently we append timestamp in metadata file name along with primary term and generation . Though we expect that for any given generation and primary term, metadata file will be uploaded only once. Uploading it twice would give IO Exception and would never succeed in first place .

Describe the solution you'd like

Simplication of naming by removing the timestamp from name.

This would make downloads easier , handling duplicate metadata files at upload time and would make deletion of translog metadata files easier.
@gbbafna gbbafna added enhancement Enhancement or improvement to existing feature or request untriaged labels Jan 2, 2023
@gbbafna gbbafna mentioned this issue Jan 2, 2023
Merged
6 tasks
@gbbafna gbbafna added Storage:Durability Issues and PRs related to the durability framework and removed untriaged labels Jan 2, 2023
@gbbafna gbbafna mentioned this issue Jan 3, 2023
Merged
6 tasks
@ashking94 ashking94 mentioned this issue Jan 4, 2023
Open
@ashking94
Copy link
Member

ashking94 commented Feb 8, 2023 •
edited
Loading

@gbbafna I have created issue #6239 for purging up older translog metadata. We can keep this story to be specifically for the naming i.e. removing the timestamp from the metadata file name.

@ashking94 ashking94 mentioned this issue Feb 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashking94 @gbbafna