Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] testNodesRemovedAfterZoneDecommission_ClusterManagerNotInToBeDecommissionedZone flaky #5220

Closed
dblock opened this issue Nov 11, 2022 · 3 comments
Assignees
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run

Comments

@dblock
Copy link
Member

dblock commented Nov 11, 2022

org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT/testNodesRemovedAfterZoneDecommission_ClusterManagerNotInToBeDecommissionedZone

https://build.ci.opensearch.org/job/gradle-check/6771/
https://build.ci.opensearch.org/job/gradle-check/6731/

@dblock dblock added bug Something isn't working untriaged flaky-test Random test failure that succeeds on second run labels Nov 11, 2022
@imRishN
Copy link
Member

imRishN commented Nov 14, 2022

Although I am not able to reproduce locally, but I believe this seem to be happening when the request lands up in a decommissioned node where the leader won't be discovered. Internally, if the node is not specified for the client then it creates a RandomizingClient and sometimes it comes out to be a decommissioned node. We can potentially avoid this by always selecting a node which will always remain in the cluster.

public static Client client(@Nullable String node) {
        if (node != null) {
            return internalCluster().client(node);
        }
        Client client = cluster().client();
        if (frequently()) {
            client = new RandomizingClient(client, random());
        }
        return client;
    }

@imRishN
Copy link
Member

imRishN commented Nov 14, 2022

Will raise a PR to implement this. This PR would resolve #5221 and #5189 as well

@kartg
Copy link
Member

kartg commented Nov 17, 2022

Closing since #5252 has been merged

@kartg kartg closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run
Projects
None yet
Development

No branches or pull requests

3 participants