Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Backpressure] Generalize TaskCancellation to support parent task cancellation at the coordinator #4766

Open
ketanv3 opened this issue Oct 13, 2022 · 0 comments
Open

[Search Backpressure] Generalize TaskCancellation to support parent task cancellation at the coordinator #4766

ketanv3 opened this issue Oct 13, 2022 · 0 comments
Labels
enhancement Enhancement or improvement to existing feature or request Indexing & Search

Comments

@ketanv3
Copy link
Contributor

ketanv3 commented Oct 13, 2022

TaskCancellation calls Task#cancel which may not cancel its descendants.

Using TaskManager#cancelTaskAndDescendants will allow us to cancel a parent task along with all its descendants, which will be useful for SearchTask cancellation at the coordinator level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Indexing & Search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mch2 @ketanv3 @anasalkouz