Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Existing BWC examples do not support more than one revision #3607

Open
peternied opened this issue Jun 16, 2022 · 0 comments
Open

[BUG] Existing BWC examples do not support more than one revision #3607

peternied opened this issue Jun 16, 2022 · 0 comments
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request

Comments

@peternied
Copy link
Member

Describe the bug
All OpenSearch components should be running backwards compatibility tests to ensure compatibility as incrementing version numbers and modify features.

In the Security codebase as we are focusing on 2.1 the process to setup the cluster for BWC is hardcoded to allow for a single previous and current version. This prevent us from following the guidance to support BWC testing for 1.3.0 and 2.0.0 versions of OpenSearch and the Security plugin.

String bwcVersion = "1.3.0.0"; // Should be an array of versions
String baseName = "securityBwcCluster"
String bwcFilePath = "src/test/resources/"
String projectVersion = "2.0.0.0"

2.times {i ->
    testClusters {
        "${baseName}$i" {
            testDistribution = "ARCHIVE"
        versions = ["1.3.0","2.0.0"] // Bad practice that duplicates information
            numberOfNodes = 3
            plugin(provider(new Callable<RegularFile>() {
                @Override
                RegularFile call() throws Exception {

See bwc-test/build.gradle in the security codebase for the full implementation

Expected behavior
We should have a better mechanism or central process to allow for appending additional versions of BWC tests as the version of the codebase increments.

Additional the distribution of these mechanism should be built into the gradle plugin that all component teams use so its easy to pick up and get updates as feature are added/introduced.

@peternied peternied added bug Something isn't working untriaged labels Jun 16, 2022
@minalsha minalsha added enhancement Enhancement or improvement to existing feature or request and removed bug Something isn't working labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

3 participants