Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Segment Store] Define RemoteDirectory interface #2993

Closed
sachinpkale opened this issue Apr 20, 2022 · 3 comments
Closed

[Remote Segment Store] Define RemoteDirectory interface #2993

sachinpkale opened this issue Apr 20, 2022 · 3 comments
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@sachinpkale
Copy link
Member

Is your feature request related to a problem? Please describe.
As described in the Feature Proposal, all the read/write operations to remote segment store will happen via RemoteDirectory interface. This task will define the RemoteDirectory interface along with corresponding RemoteIndexInput (extends IndexInput) and RemoteIndexOutput (extends IndexOutput) classes.

Describe the solution you'd like
ToDo

Describe alternatives you've considered
ToDo

Additional context
ToDo

@sachinpkale
Copy link
Member Author

sachinpkale commented Apr 26, 2022

Initial implementation can be found in the fork: https://github.com/sachinpkale/OpenSearch/blob/feature/remote_directory/server/src/main/java/org/opensearch/index/engine/RemoteDirectory.java

Corresponding RemoteIndexInput and RemoteIndexOutput.

Next steps:

  1. Move these files to correct package structure, should be under org.opensearch.index.store
  2. Add javadoc/comments - for Directory methods that will not be supported in RemoteDirectory in V1, we need to explicitly add comments on why it is not supported.
  3. Add unit tests.
  4. Raise PR to merge to main

@sachinpkale
Copy link
Member Author

Moved RemoteDirectory file under new package: org.opensearch.index.store and added javadoc/comments.

  1. RemoteDirectory
  2. RemoteIndexInput
  3. RemoteIndexOutput

Next step: Add unit tests and raise PR.

@sachinpkale
Copy link
Member Author

PR link: #3102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

2 participants