Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow setting query parameters on requests #13776

Closed
oliverlockwood opened this issue May 22, 2024 · 1 comment · Fixed by #13777
Closed

[Feature Request] Allow setting query parameters on requests #13776

oliverlockwood opened this issue May 22, 2024 · 1 comment · Fixed by #13777
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@oliverlockwood
Copy link
Contributor

Is your feature request related to a problem? Please describe

I am trying to migrate a complex project from Elasticsearch to OpenSearch. When using the RestHighLevelClient (which yes, I know is deprecated, but for various reasons, migrating away from that will be a separate follow-on piece of work!) I cannot filter out some big fields that aren't always required, which means that my search responses are much bigger than they could be; this adversely affects the performance of the application.

This problem is essentially the same as that described in #535.

Describe the solution you'd like

At a fundamental level, I'd like to be able to set a query parameter like ?filter_path=-hits.hits._source.somethingbig (as documented at https://opensearch.org/docs/2.3/opensearch/common-parameters/#filtered-responses.

I would be happy to implement this from scratch without inspecting the PR implementation of #536 which was closed due to the authors concerns about license infringement. To that end, I have deliberately not looked at that PR.

Related component

Clients

Describe alternatives you've considered

No response

Additional context

No response

@oliverlockwood oliverlockwood added enhancement Enhancement or improvement to existing feature or request untriaged labels May 22, 2024
@github-actions github-actions bot added the Clients Clients within the Core repository such as High level Rest client and low level client label May 22, 2024
oliverlockwood added a commit to dalet-oss/OpenSearch that referenced this issue May 22, 2024
oliverlockwood added a commit to dalet-oss/OpenSearch that referenced this issue May 22, 2024
…ions

Signed-off-by: Oliver Lockwood <oliver.lockwood@cantab.net>
@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.15.0 Issues and PRs related to version 2.15.0 labels May 22, 2024
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7 8 9 10]
@oliverlockwood Thanks for creating this issue, we would love a pull request to include this functionality - which I see you have already created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants