-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IpFieldMapper
should use IndexOrDocValuesQuery
where possible
#11144
Labels
enhancement
Enhancement or improvement to existing feature or request
Search:Performance
v2.12.0
Issues and PRs related to version 2.12.0
v3.0.0
Issues and PRs related to version 3.0.0
Comments
harshavamsi
added
enhancement
Enhancement or improvement to existing feature or request
untriaged
Search:Performance
labels
Nov 9, 2023
harshavamsi
added
v2.12.0
Issues and PRs related to version 2.12.0
and removed
untriaged
labels
Nov 9, 2023
This was referenced Dec 7, 2023
Hi @harshavamsi , will this require documentation for 2.12? If so, can you please create a doc issue, let me know who will be responsible for the doc PR, and add this to the unified tracker project? Thank you! |
Hi, are we on track for this to be released in 2.12 ? |
@reta Does this require documentation for 2.12? |
I believe there are no user facing changes here |
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Search Project Board
Jan 30, 2024
github-project-automation
bot
moved this to 2.12.0 (Launched)
in OpenSearch Project Roadmap
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhancement or improvement to existing feature or request
Search:Performance
v2.12.0
Issues and PRs related to version 2.12.0
v3.0.0
Issues and PRs related to version 3.0.0
Is your feature request related to a problem? Please describe.
While going through the
IpFieldMapper
class and looking throughIpFieldMapperType
I noticed that the termQuery, termsQuery, and rangeQuery all use underlying lucene index queries. The documentation also incorrectly points to the fact that IP address do not have doc_values enabled by default. This is incorrect, ref:OpenSearch/server/src/main/java/org/opensearch/index/mapper/IpFieldMapper.java
Line 89 in b78176a
Describe the solution you'd like
Wrap all three queries in
IndexOrDocValuesQuery
and add checks to ensure that we return the index query if the field is only indexed and doc_values query if we only have doc_values enabled.Describe alternatives you've considered
Alternative is to leave this as is. But there is potentially a lot of performance improvement to be had. Consider a query that looks like
We could let the range on the timestamp drive the query and use the doc_values to match the documents for the terms in the ipaddress.
Additional context
#7057
The text was updated successfully, but these errors were encountered: