Skip to content

Commit 04ddf96

Browse files
author
Bhumika Sharma
committed
Fix: updates tag name and removed lagging reason
Signed-off-by: Bhumika Sharma <bhumikka@amazon.com>
1 parent 04fff47 commit 04ddf96

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

server/src/main/java/org/opensearch/cluster/ClusterManagerMetrics.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
*/
2424
public final class ClusterManagerMetrics {
2525

26-
public static final String NODE_ID_TAG = "node_id";
26+
public static final String NODE_ID_TAG = "follower_node_id";
2727
public static final String REASON_TAG = "reason";
2828
private static final String LATENCY_METRIC_UNIT_MS = "ms";
2929
private static final String COUNTER_METRICS_UNIT = "1";

server/src/main/java/org/opensearch/cluster/coordination/Coordinator.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@
117117
import static org.opensearch.cluster.coordination.FollowersChecker.NODE_LEFT_REASON_DISCONNECTED;
118118
import static org.opensearch.cluster.coordination.FollowersChecker.NODE_LEFT_REASON_FOLLOWER_CHECK_RETRY_FAIL;
119119
import static org.opensearch.cluster.coordination.FollowersChecker.NODE_LEFT_REASON_HEALTHCHECK_FAIL;
120-
import static org.opensearch.cluster.coordination.FollowersChecker.NODE_LEFT_REASON_LAGGING;
121120
import static org.opensearch.cluster.coordination.NoClusterManagerBlockService.NO_CLUSTER_MANAGER_BLOCK_ID;
122121
import static org.opensearch.cluster.decommission.DecommissionHelper.nodeCommissioned;
123122
import static org.opensearch.gateway.ClusterStateUpdaters.hideStateIfNotRecovered;
@@ -370,7 +369,6 @@ private void removeNode(DiscoveryNode discoveryNode, String reason) {
370369
);
371370
String reasonToPublish = switch (reason) {
372371
case NODE_LEFT_REASON_DISCONNECTED -> "disconnected";
373-
case NODE_LEFT_REASON_LAGGING -> "lagging";
374372
case NODE_LEFT_REASON_FOLLOWER_CHECK_RETRY_FAIL -> "follower.check.fail";
375373
case NODE_LEFT_REASON_HEALTHCHECK_FAIL -> "health.check.fail";
376374
default -> reason;

server/src/main/java/org/opensearch/cluster/coordination/FollowersChecker.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ public class FollowersChecker {
8686
private static final Logger logger = LogManager.getLogger(FollowersChecker.class);
8787

8888
public static final String FOLLOWER_CHECK_ACTION_NAME = "internal:coordination/fault_detection/follower_check";
89-
public static final String NODE_LEFT_REASON_LAGGING = "lagging";
9089
public static final String NODE_LEFT_REASON_DISCONNECTED = "disconnected";
9190
public static final String NODE_LEFT_REASON_HEALTHCHECK_FAIL = "health check failed";
9291
public static final String NODE_LEFT_REASON_FOLLOWER_CHECK_RETRY_FAIL = "followers check retry count exceeded";

0 commit comments

Comments
 (0)