[Workspace][Bug]Fix workspace detail page issues #8317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Signed-off-by: yubonluo <yubonluo@amazon.com>
…enSearch-Dashboards into 2.17/update-workspace-detail
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Sep 27, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
reviewed
Sep 29, 2024
SuZhou-Joe
reviewed
Sep 29, 2024
src/plugins/workspace/public/components/workspace_detail/workspace_detail.tsx
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Sep 29, 2024
src/plugins/workspace/public/components/workspace_form/workspace_detail_form.tsx
Show resolved
Hide resolved
ruanyl
reviewed
Sep 29, 2024
src/plugins/workspace/public/components/workspace_detail/workspace_detail.tsx
Show resolved
Hide resolved
src/plugins/workspace/server/saved_objects/workspace_ui_settings_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Hailong-am
reviewed
Sep 29, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
previously approved these changes
Sep 30, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
ruanyl
reviewed
Sep 30, 2024
src/plugins/workspace/server/saved_objects/workspace_ui_settings_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
approved these changes
Sep 30, 2024
ruanyl
approved these changes
Sep 30, 2024
Hailong-am
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Fix workspace detail page issues Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #8317 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimzize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * add callback function to onLeave Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * navigate to workspace overview page in other tab Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * update assocation toast Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * add loding state for set default workspace button Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the comment Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 948b3d6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Fix workspace detail page issues * Changeset file for PR #8317 created/updated * optimize the code * optimzize the code * optimize the code * add callback function to onLeave * optimize the code * optimize the code * navigate to workspace overview page in other tab * optimize the code * optimize the code * optimize the code * optimize the code * optimize the code * update assocation toast * optimize the code * add loding state for set default workspace button * optimize the code * optimize the comment --------- (cherry picked from commit 948b3d6) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…8317) (opensearch-project#8387) * Fix workspace detail page issues * Changeset file for PR opensearch-project#8317 created/updated * optimize the code * optimzize the code * optimize the code * add callback function to onLeave * optimize the code * optimize the code * navigate to workspace overview page in other tab * optimize the code * optimize the code * optimize the code * optimize the code * optimize the code * update assocation toast * optimize the code * add loding state for set default workspace button * optimize the code * optimize the comment --------- (cherry picked from commit 948b3d6) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix workspace detail page issues:
Issues Resolved
Screenshot
Add a modal warning if user navigates away without saving changes in any of the tabs
Add “Set as default" button and Add a mock for the header when the workspace is set to default
2024-09-25.11.38.36.mp4
Right align the column with Related connections number:
Delete workspace overview link from detail panel and Add view workspace button
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration