-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discover] cached data structures TTL #8271
base: main
Are you sure you want to change the base?
[discover] cached data structures TTL #8271
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8271 +/- ##
==========================================
+ Coverage 64.05% 64.13% +0.07%
==========================================
Files 3741 3743 +2
Lines 88629 88812 +183
Branches 13801 13848 +47
==========================================
+ Hits 56771 56958 +187
+ Misses 31260 31238 -22
- Partials 598 616 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
If the dataset type config passes a meta object with `updateAt` within the data structure we know that the config opts into the TTL. If TTL over configuring UI setting then refetch in the case of S3 to get a new session ID in the cache. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
a8a2652
to
97e7425
Compare
Description
PR builds off of this PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8226/files
If the dataset type config passes a meta object with
updateAt
within the data structure we know that the config opts into the TTL.
If TTL over configuring UI setting then refetch in the case of S3
to get a new session ID in the cache.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Partially Resolved
n/a
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration