Fix 2.x issue #8021
Merged
Fix 2.x issue #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## backport/backport-7992-to-2.x #8021 +/- ##
=================================================================
+ Coverage 60.57% 60.61% +0.03%
=================================================================
Files 3727 3727
Lines 88295 88295
Branches 13653 13653
=================================================================
+ Hits 53486 53517 +31
+ Misses 31555 31528 -27
+ Partials 3254 3250 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
merged commit bb6a3bc
into
opensearch-project:backport/backport-7992-to-2.x
44 of 57 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit bb6a3bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 5, 2024
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ce (#8015) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7992 created/updated * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 63d0d32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix 2.x issue (#8021) Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
…ce (#8015) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7992 created/updated * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 63d0d32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix 2.x issue (#8021) Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit ee2656b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 6, 2024
…ce (#8015) (#8050) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace * Changeset file for PR #7992 created/updated * don't relay on text to drop home * don't relay on text to drop home --------- (cherry picked from commit 63d0d32) * fix 2.x issue (#8021) --------- (cherry picked from commit ee2656b) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix 2.x osd bootstrap issue for backport PR #8015
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration