Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing doc entry for content management plugin #7695

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Aug 13, 2024

Description

Add missing doc entry to docs/_sidebar.md

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@github-actions github-actions bot added seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Aug 13, 2024
@ruanyl ruanyl changed the title fix: add missing doc for content management plugin fix: add missing doc entry for content management plugin Aug 13, 2024
@ashwin-pc ashwin-pc merged commit 65ecd3b into opensearch-project:main Aug 13, 2024
11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7695-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65ecd3ba9982f65cde6250085eb119931efb360b
# Push it to GitHub
git push --set-upstream origin backport/backport-7695-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7695-to-2.x.

@ruanyl
Copy link
Member Author

ruanyl commented Aug 14, 2024

@AMoo-Miki backport 2.x failed, seems 2.x branch doesn't have docs/_sidebar.md, perhaps shouldn't backport to 2.x?

@AMoo-Miki
Copy link
Collaborator

Thanks @ruanyl. Will wait to hear from @ashwin-pc on why #5977 wasn't backported.

@ruanyl ruanyl removed the v2.17.0 label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x failed backport seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants