Fix query assist after #7492, #7546, #7540

[joshuali925]

Description

• this commit added skip(1) back to dataset manager observable: fef6156, we need to revert changes done in fix(query assist): update reading data source id from dataset manager #7464 (comment)
  • revert dataset manager observable usage in query assist to support skip(1)
  • revert dataset manager tests
• [Discover Next] Fixes Discover styles #7546 removed query editor header div, this PR adds it back to enable query editor extensions

Issues Resolved

Screenshot

Testing the changes

Changelog

• skip

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.64%. Comparing base (611f56b) to head (e37232a).
Report is 1 commits behind head on main.

Files	Patch %	Lines
.../ui/dataset_navigator/create_dataset_navigator.tsx	0.00%	1 Missing ⚠️
...ublic/query_assist/components/query_assist_bar.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7552   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files        3629     3629           
  Lines       79520    79522    +2     
  Branches    12601    12604    +3     
=======================================
+ Hits        50611    50613    +2     
  Misses      25841    25841           
  Partials     3068     3068           

Flag	Coverage Δ
Linux_1	30.76% <0.00%> (ø)
Linux_2	55.58% <ø> (ø)
Linux_3	40.23% <0.00%> (+<0.01%)	⬆️
Linux_4	31.57% <0.00%> (ø)
Windows_1	30.77% <0.00%> (ø)
Windows_2	55.53% <ø> (ø)
Windows_3	40.23% <0.00%> (-0.01%)	⬇️
Windows_4	31.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshuali925]

     │1)    dashboard app
     │       using legacy data
     │         bwc shared urls
     │           5.6 urls
     │             url with filters and query:
     │
     │      Error: expected '' to equal 'memory:>220000'
     │       at Assertion.assert (packages/osd-expect/expect.js:111:11)
     │       at Assertion.equal (packages/osd-expect/expect.js:238:8)
     │       at Context.<anonymous> (test/functional/apps/dashboard/bwc_shared_urls.js:101:26)
     │       at processTicksAndRejections (node:internal/process/task_queues:95:5)
     │       at Object.apply (packages/osd-test/src/functional_test_runner/lib/mocha/wrap_function.js:95:16)
     │ 

test failure doesn't seem related to this PR, same failure occurred in previous commit

[ashwin-pc]

Looks good, just one minor change

[ashwin-pc]

Can you add a style to the Query assist bar to add padding. You can add this to the EuiForm element

padding: $euiSizeXS;

[joshuali925]

updated. there will be a gap in between query assist bar and query editor which wasn't there in the original design

do we want to do anything for the callouts?

[ashwin-pc]

Good callout. @canascar @kgcreative what are your thoughts here?

[ashwin-pc]

The mock current has it like this:

[canascar]

The gap (padding) should probably be present above and below the success callout:

[joshuali925]

updated.

in OUI padding for callout is the space from text to the border of the colored area. to add space outside i used margin

[ananzh]

ciGroup3 failed. re-run this test.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7552-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d68c589e4bd46a737beaf8e4bfdc83fc36eb7c35
# Push it to GitHub
git push --set-upstream origin backport/backport-7552-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7552-to-2.x.

[opensearch-trigger-bot]

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7552-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d68c589e4bd46a737beaf8e4bfdc83fc36eb7c35
# Push it to GitHub
git push --set-upstream origin backport/backport-7552-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7552-to-2.16.

[joshuali925]

backported through 2411e2f

[AMoo-Miki]

Backported with #7574