Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover-next] data set picker #7426

Merged
merged 15 commits into from
Jul 24, 2024
Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jul 24, 2024

Description

Thank you @ashwin-pc @sejli for the help on this one.

Stable dataset picker for indices and index patterns.

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.60%. Comparing base (83317a2) to head (16a19ef).

Files Patch % Lines
.../data/common/search/search_source/search_source.ts 0.00% 4 Missing ⚠️
...on/index_patterns/index_patterns/index_patterns.ts 0.00% 2 Missing ⚠️
src/plugins/data/server/search/search_service.ts 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (83317a2) and HEAD (16a19ef). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (83317a2) HEAD (16a19ef)
Linux_4 1 0
Linux_3 1 0
Linux_1 1 0
Windows_2 1 0
Windows_1 1 0
Windows_4 1 0
Windows_3 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7426      +/-   ##
==========================================
- Coverage   64.13%   55.60%   -8.53%     
==========================================
  Files        3614     1211    -2403     
  Lines       78689    24942   -53747     
  Branches    12437     4246    -8191     
==========================================
- Hits        50465    13869   -36596     
+ Misses      25173    10407   -14766     
+ Partials     3051      666    -2385     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.60% <0.00%> (+0.01%) ⬆️
Linux_3 ?
Linux_4 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Given the code cutoff for 2.16 is today and this is a dependency for other related changes, Im okay merging this in as is and addressing and issues that arise from this change in a fast follow. I dont see anything inherently wrong with this change, especially since all of its features are gated behind an advanced setting

@ashwin-pc ashwin-pc merged commit 6a079d3 into opensearch-project:main Jul 24, 2024
37 of 66 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7426-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a079d3eb61e9e229457eba7d26213b50ee7a7c6
# Push it to GitHub
git push --set-upstream origin backport/backport-7426-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7426-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7426-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a079d3eb61e9e229457eba7d26213b50ee7a7c6
# Push it to GitHub
git push --set-upstream origin backport/backport-7426-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7426-to-2.16.

LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 25, 2024
* update using query manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* aggs not working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* almost there

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* stablish

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* thanks ashwin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ref name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix timefields

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* clean up some console logs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* go safer route of setting language

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* its working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix names

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* restore code editor and indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* sql df

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix external datasources again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 6a079d3)
sejli added a commit that referenced this pull request Jul 25, 2024
ashwin-pc pushed a commit that referenced this pull request Jul 25, 2024
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 25, 2024
LDrago27 added a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick

Signed-off-by: Eric <menwe@amazon.com>

* SQL keyword suggestion

Signed-off-by: Eric <menwe@amazon.com>

* column and values suggestions

Signed-off-by: Eric <menwe@amazon.com>

* adjust values suggestions and ignored token

Signed-off-by: Eric <menwe@amazon.com>

* suggestion type casting

Signed-off-by: Eric <menwe@amazon.com>

* ignore functions

Signed-off-by: Eric <menwe@amazon.com>

* case insensitive

Signed-off-by: Eric <menwe@amazon.com>

* change to use grammar for insensitive case

Signed-off-by: Eric <menwe@amazon.com>

* fix multi-line issue

Signed-off-by: Eric <menwe@amazon.com>

* code cleanup

Signed-off-by: Eric <menwe@amazon.com>

* move ppl out of scope

Signed-off-by: Eric <menwe@amazon.com>

* rename folder and add ignoring rules

Signed-off-by: Eric <menwe@amazon.com>

* resolve type issue

Signed-off-by: Eric <menwe@amazon.com>

* fix ppl suggestion provider issue

Signed-off-by: Eric <menwe@amazon.com>

* remove function suggestion

Signed-off-by: Eric <menwe@amazon.com>

* some code clean up and adding tests

Signed-off-by: Eric <menwe@amazon.com>

* cursor tests

Signed-off-by: Eric <menwe@amazon.com>

* remove testing setup

Signed-off-by: Eric <menwe@amazon.com>

* add changelog

Signed-off-by: Eric <menwe@amazon.com>

* update yarn file

Signed-off-by: Eric <menwe@amazon.com>

* add missing testing library

Signed-off-by: Eric <menwe@amazon.com>

* MDS integration

Signed-off-by: Eric <menwe@amazon.com>

* minor interface change and disable word based suggestion

Signed-off-by: Eric <menwe@amazon.com>

* update ID_LITERAL and recompile grammar

Signed-off-by: Eric <menwe@amazon.com>

* column suggest for agg function

Signed-off-by: Eric <menwe@amazon.com>

* revert version

Signed-off-by: Eric <menwe@amazon.com>

* opensearch sql syntax highlighting

Signed-off-by: Eric <menwe@amazon.com>

* add utility tests

Signed-off-by: Eric <menwe@amazon.com>

* symbol table test

Signed-off-by: Eric <menwe@amazon.com>

* error listener test

Signed-off-by: Eric <menwe@amazon.com>

* parse test

Signed-off-by: Eric <menwe@amazon.com>

* add suggestion provider to single line query editor

Signed-off-by: Eric <menwe@amazon.com>

* remove one test

Signed-off-by: Eric <menwe@amazon.com>

* add connection service type

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7440 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* aggs not working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* almost there

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* stablish

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* thanks ashwin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ref name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix timefields

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* clean up some console logs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* go safer route of setting language

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* its working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix names

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* restore code editor and indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* sql df

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix external datasources again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add unit test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change from nested ternary to if else

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add more unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix typo

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7435 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------

Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Sean Li <lnse@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick

Signed-off-by: Eric <menwe@amazon.com>

* SQL keyword suggestion

Signed-off-by: Eric <menwe@amazon.com>

* column and values suggestions

Signed-off-by: Eric <menwe@amazon.com>

* adjust values suggestions and ignored token

Signed-off-by: Eric <menwe@amazon.com>

* suggestion type casting

Signed-off-by: Eric <menwe@amazon.com>

* ignore functions

Signed-off-by: Eric <menwe@amazon.com>

* case insensitive

Signed-off-by: Eric <menwe@amazon.com>

* change to use grammar for insensitive case

Signed-off-by: Eric <menwe@amazon.com>

* fix multi-line issue

Signed-off-by: Eric <menwe@amazon.com>

* code cleanup

Signed-off-by: Eric <menwe@amazon.com>

* move ppl out of scope

Signed-off-by: Eric <menwe@amazon.com>

* rename folder and add ignoring rules

Signed-off-by: Eric <menwe@amazon.com>

* resolve type issue

Signed-off-by: Eric <menwe@amazon.com>

* fix ppl suggestion provider issue

Signed-off-by: Eric <menwe@amazon.com>

* remove function suggestion

Signed-off-by: Eric <menwe@amazon.com>

* some code clean up and adding tests

Signed-off-by: Eric <menwe@amazon.com>

* cursor tests

Signed-off-by: Eric <menwe@amazon.com>

* remove testing setup

Signed-off-by: Eric <menwe@amazon.com>

* add changelog

Signed-off-by: Eric <menwe@amazon.com>

* update yarn file

Signed-off-by: Eric <menwe@amazon.com>

* add missing testing library

Signed-off-by: Eric <menwe@amazon.com>

* MDS integration

Signed-off-by: Eric <menwe@amazon.com>

* minor interface change and disable word based suggestion

Signed-off-by: Eric <menwe@amazon.com>

* update ID_LITERAL and recompile grammar

Signed-off-by: Eric <menwe@amazon.com>

* column suggest for agg function

Signed-off-by: Eric <menwe@amazon.com>

* revert version

Signed-off-by: Eric <menwe@amazon.com>

* opensearch sql syntax highlighting

Signed-off-by: Eric <menwe@amazon.com>

* add utility tests

Signed-off-by: Eric <menwe@amazon.com>

* symbol table test

Signed-off-by: Eric <menwe@amazon.com>

* error listener test

Signed-off-by: Eric <menwe@amazon.com>

* parse test

Signed-off-by: Eric <menwe@amazon.com>

* add suggestion provider to single line query editor

Signed-off-by: Eric <menwe@amazon.com>

* remove one test

Signed-off-by: Eric <menwe@amazon.com>

* add connection service type

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7440 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* aggs not working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* almost there

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* stablish

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* thanks ashwin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ref name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix timefields

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* clean up some console logs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* go safer route of setting language

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* its working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix names

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* restore code editor and indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* sql df

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix external datasources again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add unit test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change from nested ternary to if else

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add more unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix typo

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7435 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------

Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Sean Li <lnse@amazon.com>
(cherry picked from commit 0515fb2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla added a commit that referenced this pull request Jul 25, 2024
LDrago27 pushed a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)


(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick



* SQL keyword suggestion



* column and values suggestions



* adjust values suggestions and ignored token



* suggestion type casting



* ignore functions



* case insensitive



* change to use grammar for insensitive case



* fix multi-line issue



* code cleanup



* move ppl out of scope



* rename folder and add ignoring rules



* resolve type issue



* fix ppl suggestion provider issue



* remove function suggestion



* some code clean up and adding tests



* cursor tests



* remove testing setup



* add changelog



* update yarn file



* add missing testing library



* MDS integration



* minor interface change and disable word based suggestion



* update ID_LITERAL and recompile grammar



* column suggest for agg function



* revert version



* opensearch sql syntax highlighting



* add utility tests



* symbol table test



* error listener test



* parse test



* add suggestion provider to single line query editor



* remove one test



* add connection service type



---------


(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.


(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs



* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit



* feat: add unit test



* feat: revert the home related change



* fix: overview error in all use case when workspace is enabled



* fix: update snapshot



* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed



* feat: hide expand icon in left navigation



* feat: update



---------




(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin



* Changeset file for PR #7440 created/updated

---------



(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager



* aggs not working



* almost there



* stablish



* thanks ashwin



* update ref name



* fix timefields



* clean up some console logs



* go safer route of setting language



* its working again



* fix names



* restore code editor and indices



* sql df



* fix external datasources again



---------


(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field



* add unit test



* change from nested ternary to if else



* add more unit tests



* change unit tests



* fix typo



---------


(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page



* Changeset file for PR #7435 created/updated

---------



(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------








(cherry picked from commit 0515fb2)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Sean Li <lnse@amazon.com>
kavilla added a commit that referenced this pull request Jul 26, 2024
)

* Revert "Revert "[Discover-next] data set picker (#7426)" (#7479)"

This reverts commit 2208df9.

* fix(query assist): update reading data source id from dataset manager (#7464)

* revert to read datasource id from index pattern

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* add dataset mock to query mock

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update query assist to use dataset manager

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* use selected dataset state instead of relying on rerender

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove skip 1 in dataset observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update dataset_manager tests

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* [Auto Suggest] DQL autosuggest with ANTLR (#7467)

* Antlr autocomplete (#7159)

* dql grammar with rudamentary testing parser

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* show suggestion of fields depending on current index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* basic code completion with fields populated

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* updated grammar and generated for better group handling

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add ignored tokens

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console logs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* dql Antlr autocomplete (#7160)

* re-add provider for sql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added temporary fix for language providor to appear for more than one language

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove EOF in parser to fix suggestions

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use custom version of cursor token index for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implemented value suggestions based on field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* set param type

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update grouping grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix grammar for dots in field and value term search with spaces

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* value suggestions match field to avoid failing api call and to find assc keyword field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update value suggestions from partially formed value

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* refactor value suggestions and change fieldval listener to visitor

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implement value suggestions within phrases

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* make grammar more readable

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename grammar parser rules

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* bring back minimal autocomplete optimized grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* enable partially complete value suggestion for value groups

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove number as lexer rule

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix cursor import and clean up

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix completion item range to be current word

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update cursor to use monaco position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* cursor index to use position directly

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move language registration into render function to handle new languages

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include auto closing quotes and parenthesis for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename generated file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include single line editor closing pairs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Changeset file for PR #7391 created/updated

* add license and fix linting

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* modify grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add tests for fields and keywords

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move dql test constants to separate file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update an import

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use updated dataset for index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console log

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [tests][discover-next] update the tests and async nature of the dataset navigator (#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* bad fingers accidentally hit the x button

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [DataSet Navigator] Rewire S3 components (#7470)

* rewiring databases back into navigator

Signed-off-by: Sean Li <lnse@amazon.com>

* fixing async query support

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>

* Fix UI and detection of external data source in query assist (#7494)

* fix(queryEditorExtensions): use dataset manager to determine external datasource

Remove datasource and indexpattern since they are no longer the source
of truth after dataset manager is added, and they are not used in query
enhancement plugin.

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* fix(queryAssist): enable click to change language in banner

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* fix(queryAssist): hide query assist bar if editor is collapsed

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* pass in index patterns

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)

* add tests for sql autocomplete rule processing

Signed-off-by: Eric <menwe@amazon.com>

* refer to monaco type directly

Signed-off-by: Eric <menwe@amazon.com>

* remove unnecessary antlr auto generated files

Signed-off-by: Eric <menwe@amazon.com>

* inital adoption of dataSet manager

Signed-off-by: Eric <menwe@amazon.com>

* mds support

Signed-off-by: Eric <menwe@amazon.com>

* remove test that are failed due to adopting dataSet manager

Signed-off-by: Eric <menwe@amazon.com>

* add changelog

Signed-off-by: Eric <menwe@amazon.com>

* fix(query assist): update reading data source id from dataset manager (#7464)

* revert to read datasource id from index pattern

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* add dataset mock to query mock

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update query assist to use dataset manager

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* use selected dataset state instead of relying on rerender

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove skip 1 in dataset observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update dataset_manager tests

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update utils

Signed-off-by: Eric <menwe@amazon.com>

* keep with observable and remove values suggestion

Signed-off-by: Eric <menwe@amazon.com>

* update unit tests

Signed-off-by: Eric <menwe@amazon.com>

* [Auto Suggest] DQL autosuggest with ANTLR (#7467)

* Antlr autocomplete (#7159)

* dql grammar with rudamentary testing parser

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* show suggestion of fields depending on current index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* basic code completion with fields populated

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* updated grammar and generated for better group handling

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add ignored tokens

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console logs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* dql Antlr autocomplete (#7160)

* re-add provider for sql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added temporary fix for language providor to appear for more than one language

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove EOF in parser to fix suggestions

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use custom version of cursor token index for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implemented value suggestions based on field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* set param type

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update grouping grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix grammar for dots in field and value term search with spaces

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* value suggestions match field to avoid failing api call and to find assc keyword field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update value suggestions from partially formed value

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* refactor value suggestions and change fieldval listener to visitor

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implement value suggestions within phrases

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* make grammar more readable

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename grammar parser rules

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* bring back minimal autocomplete optimized grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* enable partially complete value suggestion for value groups

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove number as lexer rule

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix cursor import and clean up

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix completion item range to be current word

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update cursor to use monaco position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* cursor index to use position directly

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move language registration into render function to handle new languages

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include auto closing quotes and parenthesis for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename generated file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include single line editor closing pairs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Changeset file for PR #7391 created/updated

* add license and fix linting

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* modify grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add tests for fields and keywords

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move dql test constants to separate file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update an import

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use updated dataset for index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console log

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [tests][discover-next] update the tests and async nature of the dataset navigator (#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* bad fingers accidentally hit the x button

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* resolve conflicts

Signed-off-by: Eric <menwe@amazon.com>

* fix one minor linting

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

* More styling on query enhancement UI  styling (#7496)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Auto Suggest] DQL Updates (#7498)

* update code completion to not return for visualize

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update types to match completionitemkind

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix some typing issues

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* delete manual changelogs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fixing sessionId support

Signed-off-by: Sean Li <lnse@amazon.com>

* remove height

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Revert "[Auto Suggest] DQL Updates (#7498)"

This reverts commit 27a74ab.

* Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)"

This reverts commit 9f68352.

* Revert "[Auto Suggest] DQL autosuggest with ANTLR (#7467)"

This reverts commit 74b03e9.

* fixing typing issue

Signed-off-by: Sean Li <lnse@amazon.com>

* remove unused export

Signed-off-by: Sean Li <lnse@amazon.com>

* fix texts and some state mgmt

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix file

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* more clean up

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* default to false

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* only push the set with enhancements

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix two tests

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* render hell

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* test update

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* passing in settings

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* add changelog

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Sean Li <lnse@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2024
)

* Revert "Revert "[Discover-next] data set picker (#7426)" (#7479)"

This reverts commit 2208df9.

* fix(query assist): update reading data source id from dataset manager (#7464)

* revert to read datasource id from index pattern

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* add dataset mock to query mock

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update query assist to use dataset manager

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* use selected dataset state instead of relying on rerender

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove skip 1 in dataset observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update dataset_manager tests

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* [Auto Suggest] DQL autosuggest with ANTLR (#7467)

* Antlr autocomplete (#7159)

* dql grammar with rudamentary testing parser

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* show suggestion of fields depending on current index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* basic code completion with fields populated

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* updated grammar and generated for better group handling

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add ignored tokens

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console logs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* dql Antlr autocomplete (#7160)

* re-add provider for sql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added temporary fix for language providor to appear for more than one language

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove EOF in parser to fix suggestions

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use custom version of cursor token index for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implemented value suggestions based on field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* set param type

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update grouping grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix grammar for dots in field and value term search with spaces

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* value suggestions match field to avoid failing api call and to find assc keyword field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update value suggestions from partially formed value

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* refactor value suggestions and change fieldval listener to visitor

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implement value suggestions within phrases

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* make grammar more readable

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename grammar parser rules

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* bring back minimal autocomplete optimized grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* enable partially complete value suggestion for value groups

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove number as lexer rule

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix cursor import and clean up

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix completion item range to be current word

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update cursor to use monaco position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* cursor index to use position directly

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move language registration into render function to handle new languages

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include auto closing quotes and parenthesis for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename generated file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include single line editor closing pairs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Changeset file for PR #7391 created/updated

* add license and fix linting

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* modify grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add tests for fields and keywords

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move dql test constants to separate file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update an import

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use updated dataset for index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console log

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [tests][discover-next] update the tests and async nature of the dataset navigator (#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* bad fingers accidentally hit the x button

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [DataSet Navigator] Rewire S3 components (#7470)

* rewiring databases back into navigator

Signed-off-by: Sean Li <lnse@amazon.com>

* fixing async query support

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>

* Fix UI and detection of external data source in query assist (#7494)

* fix(queryEditorExtensions): use dataset manager to determine external datasource

Remove datasource and indexpattern since they are no longer the source
of truth after dataset manager is added, and they are not used in query
enhancement plugin.

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* fix(queryAssist): enable click to change language in banner

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* fix(queryAssist): hide query assist bar if editor is collapsed

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* pass in index patterns

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)

* add tests for sql autocomplete rule processing

Signed-off-by: Eric <menwe@amazon.com>

* refer to monaco type directly

Signed-off-by: Eric <menwe@amazon.com>

* remove unnecessary antlr auto generated files

Signed-off-by: Eric <menwe@amazon.com>

* inital adoption of dataSet manager

Signed-off-by: Eric <menwe@amazon.com>

* mds support

Signed-off-by: Eric <menwe@amazon.com>

* remove test that are failed due to adopting dataSet manager

Signed-off-by: Eric <menwe@amazon.com>

* add changelog

Signed-off-by: Eric <menwe@amazon.com>

* fix(query assist): update reading data source id from dataset manager (#7464)

* revert to read datasource id from index pattern

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* add dataset mock to query mock

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update query assist to use dataset manager

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* use selected dataset state instead of relying on rerender

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove skip 1 in dataset observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update dataset_manager tests

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update utils

Signed-off-by: Eric <menwe@amazon.com>

* keep with observable and remove values suggestion

Signed-off-by: Eric <menwe@amazon.com>

* update unit tests

Signed-off-by: Eric <menwe@amazon.com>

* [Auto Suggest] DQL autosuggest with ANTLR (#7467)

* Antlr autocomplete (#7159)

* dql grammar with rudamentary testing parser

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* show suggestion of fields depending on current index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* basic code completion with fields populated

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* updated grammar and generated for better group handling

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add ignored tokens

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console logs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* dql Antlr autocomplete (#7160)

* re-add provider for sql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added temporary fix for language providor to appear for more than one language

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove EOF in parser to fix suggestions

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use custom version of cursor token index for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implemented value suggestions based on field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* set param type

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update grouping grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix grammar for dots in field and value term search with spaces

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* value suggestions match field to avoid failing api call and to find assc keyword field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update value suggestions from partially formed value

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* refactor value suggestions and change fieldval listener to visitor

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implement value suggestions within phrases

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* make grammar more readable

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename grammar parser rules

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* bring back minimal autocomplete optimized grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* enable partially complete value suggestion for value groups

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove number as lexer rule

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix cursor import and clean up

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix completion item range to be current word

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update cursor to use monaco position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* cursor index to use position directly

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move language registration into render function to handle new languages

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include auto closing quotes and parenthesis for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename generated file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include single line editor closing pairs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Changeset file for PR #7391 created/updated

* add license and fix linting

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* modify grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add tests for fields and keywords

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move dql test constants to separate file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update an import

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use updated dataset for index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console log

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [tests][discover-next] update the tests and async nature of the dataset navigator (#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* bad fingers accidentally hit the x button

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* resolve conflicts

Signed-off-by: Eric <menwe@amazon.com>

* fix one minor linting

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

* More styling on query enhancement UI  styling (#7496)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Auto Suggest] DQL Updates (#7498)

* update code completion to not return for visualize

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update types to match completionitemkind

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix some typing issues

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* delete manual changelogs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fixing sessionId support

Signed-off-by: Sean Li <lnse@amazon.com>

* remove height

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Revert "[Auto Suggest] DQL Updates (#7498)"

This reverts commit 27a74ab.

* Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)"

This reverts commit 9f68352.

* Revert "[Auto Suggest] DQL autosuggest with ANTLR (#7467)"

This reverts commit 74b03e9.

* fixing typing issue

Signed-off-by: Sean Li <lnse@amazon.com>

* remove unused export

Signed-off-by: Sean Li <lnse@amazon.com>

* fix texts and some state mgmt

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix file

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* more clean up

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* default to false

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* only push the set with enhancements

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix two tests

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* render hell

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* test update

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* passing in settings

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* add changelog

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Sean Li <lnse@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 3168283)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2024
)

* Revert "Revert "[Discover-next] data set picker (#7426)" (#7479)"

This reverts commit 2208df9.

* fix(query assist): update reading data source id from dataset manager (#7464)

* revert to read datasource id from index pattern

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* add dataset mock to query mock

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update query assist to use dataset manager

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* use selected dataset state instead of relying on rerender

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove skip 1 in dataset observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update dataset_manager tests

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* [Auto Suggest] DQL autosuggest with ANTLR (#7467)

* Antlr autocomplete (#7159)

* dql grammar with rudamentary testing parser

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* show suggestion of fields depending on current index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* basic code completion with fields populated

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* updated grammar and generated for better group handling

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add ignored tokens

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console logs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* dql Antlr autocomplete (#7160)

* re-add provider for sql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added temporary fix for language providor to appear for more than one language

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove EOF in parser to fix suggestions

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use custom version of cursor token index for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implemented value suggestions based on field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* set param type

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update grouping grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix grammar for dots in field and value term search with spaces

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* value suggestions match field to avoid failing api call and to find assc keyword field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update value suggestions from partially formed value

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* refactor value suggestions and change fieldval listener to visitor

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implement value suggestions within phrases

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* make grammar more readable

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename grammar parser rules

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* bring back minimal autocomplete optimized grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* enable partially complete value suggestion for value groups

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove number as lexer rule

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix cursor import and clean up

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix completion item range to be current word

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update cursor to use monaco position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* cursor index to use position directly

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move language registration into render function to handle new languages

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include auto closing quotes and parenthesis for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename generated file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include single line editor closing pairs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Changeset file for PR #7391 created/updated

* add license and fix linting

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* modify grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add tests for fields and keywords

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move dql test constants to separate file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update an import

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use updated dataset for index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console log

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [tests][discover-next] update the tests and async nature of the dataset navigator (#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* bad fingers accidentally hit the x button

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [DataSet Navigator] Rewire S3 components (#7470)

* rewiring databases back into navigator

Signed-off-by: Sean Li <lnse@amazon.com>

* fixing async query support

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>

* Fix UI and detection of external data source in query assist (#7494)

* fix(queryEditorExtensions): use dataset manager to determine external datasource

Remove datasource and indexpattern since they are no longer the source
of truth after dataset manager is added, and they are not used in query
enhancement plugin.

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* fix(queryAssist): enable click to change language in banner

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* fix(queryAssist): hide query assist bar if editor is collapsed

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* pass in index patterns

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)

* add tests for sql autocomplete rule processing

Signed-off-by: Eric <menwe@amazon.com>

* refer to monaco type directly

Signed-off-by: Eric <menwe@amazon.com>

* remove unnecessary antlr auto generated files

Signed-off-by: Eric <menwe@amazon.com>

* inital adoption of dataSet manager

Signed-off-by: Eric <menwe@amazon.com>

* mds support

Signed-off-by: Eric <menwe@amazon.com>

* remove test that are failed due to adopting dataSet manager

Signed-off-by: Eric <menwe@amazon.com>

* add changelog

Signed-off-by: Eric <menwe@amazon.com>

* fix(query assist): update reading data source id from dataset manager (#7464)

* revert to read datasource id from index pattern

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* add dataset mock to query mock

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update query assist to use dataset manager

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* use selected dataset state instead of relying on rerender

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove skip 1 in dataset observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update dataset_manager tests

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update utils

Signed-off-by: Eric <menwe@amazon.com>

* keep with observable and remove values suggestion

Signed-off-by: Eric <menwe@amazon.com>

* update unit tests

Signed-off-by: Eric <menwe@amazon.com>

* [Auto Suggest] DQL autosuggest with ANTLR (#7467)

* Antlr autocomplete (#7159)

* dql grammar with rudamentary testing parser

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* show suggestion of fields depending on current index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* basic code completion with fields populated

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* updated grammar and generated for better group handling

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add ignored tokens

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console logs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* dql Antlr autocomplete (#7160)

* re-add provider for sql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added temporary fix for language providor to appear for more than one language

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove EOF in parser to fix suggestions

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use custom version of cursor token index for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implemented value suggestions based on field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* set param type

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update grouping grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix grammar for dots in field and value term search with spaces

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* value suggestions match field to avoid failing api call and to find assc keyword field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update value suggestions from partially formed value

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* refactor value suggestions and change fieldval listener to visitor

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implement value suggestions within phrases

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* make grammar more readable

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename grammar parser rules

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* bring back minimal autocomplete optimized grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* enable partially complete value suggestion for value groups

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove number as lexer rule

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix cursor import and clean up

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix completion item range to be current word

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update cursor to use monaco position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* cursor index to use position directly

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move language registration into render function to handle new languages

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include auto closing quotes and parenthesis for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename generated file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include single line editor closing pairs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Changeset file for PR #7391 created/updated

* add license and fix linting

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* modify grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add tests for fields and keywords

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move dql test constants to separate file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update an import

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use updated dataset for index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console log

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [tests][discover-next] update the tests and async nature of the dataset navigator (#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* bad fingers accidentally hit the x button

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* resolve conflicts

Signed-off-by: Eric <menwe@amazon.com>

* fix one minor linting

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

* More styling on query enhancement UI  styling (#7496)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Auto Suggest] DQL Updates (#7498)

* update code completion to not return for visualize

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update types to match completionitemkind

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix some typing issues

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* delete manual changelogs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fixing sessionId support

Signed-off-by: Sean Li <lnse@amazon.com>

* remove height

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Revert "[Auto Suggest] DQL Updates (#7498)"

This reverts commit 27a74ab.

* Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)"

This reverts commit 9f68352.

* Revert "[Auto Suggest] DQL autosuggest with ANTLR (#7467)"

This reverts commit 74b03e9.

* fixing typing issue

Signed-off-by: Sean Li <lnse@amazon.com>

* remove unused export

Signed-off-by: Sean Li <lnse@amazon.com>

* fix texts and some state mgmt

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix file

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* more clean up

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* default to false

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* only push the set with enhancements

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix two tests

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* render hell

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* test update

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* passing in settings

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* add changelog

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Sean Li <lnse@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 3168283)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc added a commit that referenced this pull request Jul 29, 2024
) (#7532)

* Revert "Revert "[Discover-next] data set picker (#7426)" (#7479)"

This reverts commit 2208df9.

* fix(query assist): update reading data source id from dataset manager (#7464)

* revert to read datasource id from index pattern



* add dataset mock to query mock



* update query assist to use dataset manager



* use selected dataset state instead of relying on rerender



* remove skip 1 in dataset observable



* update dataset_manager tests



---------



* [Auto Suggest] DQL autosuggest with ANTLR (#7467)

* Antlr autocomplete (#7159)

* dql grammar with rudamentary testing parser



* show suggestion of fields depending on current index pattern



* basic code completion with fields populated



* updated grammar and generated for better group handling



* add ignored tokens



* remove console logs



---------



* dql Antlr autocomplete (#7160)

* re-add provider for sql



* added temporary fix for language providor to appear for more than one language



---------



* remove EOF in parser to fix suggestions



* use custom version of cursor token index for dql



* implemented value suggestions based on field



* set param type



* update grouping grammar



* fix grammar for dots in field and value term search with spaces



* value suggestions match field to avoid failing api call and to find assc keyword field



* update value suggestions from partially formed value



* refactor value suggestions and change fieldval listener to visitor



* implement value suggestions within phrases



* make grammar more readable



* rename grammar parser rules



* bring back minimal autocomplete optimized grammar



* enable partially complete value suggestion for value groups



* remove number as lexer rule



* fix cursor import and clean up



* fix completion item range to be current word



* update cursor to use monaco position



* cursor index to use position directly



* move language registration into render function to handle new languages



* include auto closing quotes and parenthesis for dql



* rename generated file



* include single line editor closing pairs



* Changeset file for PR #7391 created/updated

* add license and fix linting



* modify grammar



* add tests for fields and keywords



* move dql test constants to separate file



* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position



* update an import



* use updated dataset for index pattern



* remove console log



---------




* [tests][discover-next] update the tests and async nature of the dataset navigator (#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.



* bad fingers accidentally hit the x button



---------



* update snapshot



* [DataSet Navigator] Rewire S3 components (#7470)

* rewiring databases back into navigator



* fixing async query support



---------



* Fix UI and detection of external data source in query assist (#7494)

* fix(queryEditorExtensions): use dataset manager to determine external datasource

Remove datasource and indexpattern since they are no longer the source
of truth after dataset manager is added, and they are not used in query
enhancement plugin.



* fix(queryAssist): enable click to change language in banner



* fix(queryAssist): hide query assist bar if editor is collapsed



---------



* pass in index patterns



* [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)

* add tests for sql autocomplete rule processing



* refer to monaco type directly



* remove unnecessary antlr auto generated files



* inital adoption of dataSet manager



* mds support



* remove test that are failed due to adopting dataSet manager



* add changelog



* fix(query assist): update reading data source id from dataset manager (#7464)

* revert to read datasource id from index pattern



* add dataset mock to query mock



* update query assist to use dataset manager



* use selected dataset state instead of relying on rerender



* remove skip 1 in dataset observable



* update dataset_manager tests



---------



* update utils



* keep with observable and remove values suggestion



* update unit tests



* [Auto Suggest] DQL autosuggest with ANTLR (#7467)

* Antlr autocomplete (#7159)

* dql grammar with rudamentary testing parser



* show suggestion of fields depending on current index pattern



* basic code completion with fields populated



* updated grammar and generated for better group handling



* add ignored tokens



* remove console logs



---------



* dql Antlr autocomplete (#7160)

* re-add provider for sql



* added temporary fix for language providor to appear for more than one language



---------



* remove EOF in parser to fix suggestions



* use custom version of cursor token index for dql



* implemented value suggestions based on field



* set param type



* update grouping grammar



* fix grammar for dots in field and value term search with spaces



* value suggestions match field to avoid failing api call and to find assc keyword field



* update value suggestions from partially formed value



* refactor value suggestions and change fieldval listener to visitor



* implement value suggestions within phrases



* make grammar more readable



* rename grammar parser rules



* bring back minimal autocomplete optimized grammar



* enable partially complete value suggestion for value groups



* remove number as lexer rule



* fix cursor import and clean up



* fix completion item range to be current word



* update cursor to use monaco position



* cursor index to use position directly



* move language registration into render function to handle new languages



* include auto closing quotes and parenthesis for dql



* rename generated file



* include single line editor closing pairs



* Changeset file for PR #7391 created/updated

* add license and fix linting



* modify grammar



* add tests for fields and keywords



* move dql test constants to separate file



* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position



* update an import



* use updated dataset for index pattern



* remove console log



---------




* [tests][discover-next] update the tests and async nature of the dataset navigator (#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.



* bad fingers accidentally hit the x button



---------



* resolve conflicts



* fix one minor linting



---------












* More styling on query enhancement UI  styling (#7496)



* [Auto Suggest] DQL Updates (#7498)

* update code completion to not return for visualize



* update types to match completionitemkind



---------



* fix some typing issues



* delete manual changelogs



* fixing sessionId support



* remove height



* Revert "[Auto Suggest] DQL Updates (#7498)"

This reverts commit 27a74ab.

* Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)"

This reverts commit 9f68352.

* Revert "[Auto Suggest] DQL autosuggest with ANTLR (#7467)"

This reverts commit 74b03e9.

* fixing typing issue



* remove unused export



* fix texts and some state mgmt



* fix file



* update snapshot



* more clean up



* default to false



* only push the set with enhancements



* fix two tests



* render hell



* test update



* passing in settings



* add changelog



---------















(cherry picked from commit 3168283)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Sean Li <lnse@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
* update using query manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* aggs not working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* almost there

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* stablish

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* thanks ashwin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ref name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix timefields

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* clean up some console logs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* go safer route of setting language

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* its working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix names

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* restore code editor and indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* sql df

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix external datasources again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
…ensearch-project#7492)

* Revert "Revert "[Discover-next] data set picker (opensearch-project#7426)" (opensearch-project#7479)"

This reverts commit 2208df9.

* fix(query assist): update reading data source id from dataset manager (opensearch-project#7464)

* revert to read datasource id from index pattern

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* add dataset mock to query mock

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update query assist to use dataset manager

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* use selected dataset state instead of relying on rerender

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove skip 1 in dataset observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update dataset_manager tests

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* [Auto Suggest] DQL autosuggest with ANTLR (opensearch-project#7467)

* Antlr autocomplete (opensearch-project#7159)

* dql grammar with rudamentary testing parser

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* show suggestion of fields depending on current index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* basic code completion with fields populated

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* updated grammar and generated for better group handling

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add ignored tokens

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console logs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* dql Antlr autocomplete (opensearch-project#7160)

* re-add provider for sql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added temporary fix for language providor to appear for more than one language

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove EOF in parser to fix suggestions

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use custom version of cursor token index for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implemented value suggestions based on field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* set param type

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update grouping grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix grammar for dots in field and value term search with spaces

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* value suggestions match field to avoid failing api call and to find assc keyword field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update value suggestions from partially formed value

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* refactor value suggestions and change fieldval listener to visitor

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implement value suggestions within phrases

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* make grammar more readable

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename grammar parser rules

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* bring back minimal autocomplete optimized grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* enable partially complete value suggestion for value groups

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove number as lexer rule

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix cursor import and clean up

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix completion item range to be current word

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update cursor to use monaco position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* cursor index to use position directly

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move language registration into render function to handle new languages

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include auto closing quotes and parenthesis for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename generated file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include single line editor closing pairs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Changeset file for PR opensearch-project#7391 created/updated

* add license and fix linting

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* modify grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add tests for fields and keywords

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move dql test constants to separate file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update an import

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use updated dataset for index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console log

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [tests][discover-next] update the tests and async nature of the dataset navigator (opensearch-project#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* bad fingers accidentally hit the x button

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [DataSet Navigator] Rewire S3 components (opensearch-project#7470)

* rewiring databases back into navigator

Signed-off-by: Sean Li <lnse@amazon.com>

* fixing async query support

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>

* Fix UI and detection of external data source in query assist (opensearch-project#7494)

* fix(queryEditorExtensions): use dataset manager to determine external datasource

Remove datasource and indexpattern since they are no longer the source
of truth after dataset manager is added, and they are not used in query
enhancement plugin.

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* fix(queryAssist): enable click to change language in banner

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* fix(queryAssist): hide query assist bar if editor is collapsed

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* pass in index patterns

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (opensearch-project#7463)

* add tests for sql autocomplete rule processing

Signed-off-by: Eric <menwe@amazon.com>

* refer to monaco type directly

Signed-off-by: Eric <menwe@amazon.com>

* remove unnecessary antlr auto generated files

Signed-off-by: Eric <menwe@amazon.com>

* inital adoption of dataSet manager

Signed-off-by: Eric <menwe@amazon.com>

* mds support

Signed-off-by: Eric <menwe@amazon.com>

* remove test that are failed due to adopting dataSet manager

Signed-off-by: Eric <menwe@amazon.com>

* add changelog

Signed-off-by: Eric <menwe@amazon.com>

* fix(query assist): update reading data source id from dataset manager (opensearch-project#7464)

* revert to read datasource id from index pattern

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* add dataset mock to query mock

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update query assist to use dataset manager

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* use selected dataset state instead of relying on rerender

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove skip 1 in dataset observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update dataset_manager tests

Signed-off-by: Joshua Li <joshuali925@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* update utils

Signed-off-by: Eric <menwe@amazon.com>

* keep with observable and remove values suggestion

Signed-off-by: Eric <menwe@amazon.com>

* update unit tests

Signed-off-by: Eric <menwe@amazon.com>

* [Auto Suggest] DQL autosuggest with ANTLR (opensearch-project#7467)

* Antlr autocomplete (opensearch-project#7159)

* dql grammar with rudamentary testing parser

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* show suggestion of fields depending on current index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* basic code completion with fields populated

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* updated grammar and generated for better group handling

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add ignored tokens

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console logs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* dql Antlr autocomplete (opensearch-project#7160)

* re-add provider for sql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added temporary fix for language providor to appear for more than one language

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove EOF in parser to fix suggestions

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use custom version of cursor token index for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implemented value suggestions based on field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* set param type

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update grouping grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix grammar for dots in field and value term search with spaces

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* value suggestions match field to avoid failing api call and to find assc keyword field

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update value suggestions from partially formed value

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* refactor value suggestions and change fieldval listener to visitor

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* implement value suggestions within phrases

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* make grammar more readable

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename grammar parser rules

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* bring back minimal autocomplete optimized grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* enable partially complete value suggestion for value groups

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove number as lexer rule

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix cursor import and clean up

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix completion item range to be current word

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update cursor to use monaco position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* cursor index to use position directly

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move language registration into render function to handle new languages

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include auto closing quotes and parenthesis for dql

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* rename generated file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* include single line editor closing pairs

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Changeset file for PR opensearch-project#7391 created/updated

* add license and fix linting

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* modify grammar

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* add tests for fields and keywords

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* move dql test constants to separate file

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update an import

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* use updated dataset for index pattern

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* remove console log

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [tests][discover-next] update the tests and async nature of the dataset navigator (opensearch-project#7489)

* [tests][discover-next] update the tests and async nature of the dataset manager

Address test failures related to the dataset navigator.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* bad fingers accidentally hit the x button

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* resolve conflicts

Signed-off-by: Eric <menwe@amazon.com>

* fix one minor linting

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

* More styling on query enhancement UI  styling (opensearch-project#7496)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Auto Suggest] DQL Updates (opensearch-project#7498)

* update code completion to not return for visualize

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update types to match completionitemkind

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix some typing issues

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* delete manual changelogs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fixing sessionId support

Signed-off-by: Sean Li <lnse@amazon.com>

* remove height

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Revert "[Auto Suggest] DQL Updates (opensearch-project#7498)"

This reverts commit 27a74ab.

* Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (opensearch-project#7463)"

This reverts commit 9f68352.

* Revert "[Auto Suggest] DQL autosuggest with ANTLR (opensearch-project#7467)"

This reverts commit 74b03e9.

* fixing typing issue

Signed-off-by: Sean Li <lnse@amazon.com>

* remove unused export

Signed-off-by: Sean Li <lnse@amazon.com>

* fix texts and some state mgmt

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix file

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* more clean up

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* default to false

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* only push the set with enhancements

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix two tests

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* render hell

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* test update

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* passing in settings

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* add changelog

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Sean Li <lnse@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants