-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x][MDS] Observability Datasource Plugin migration with MDS support for Data Connection Table #7371
[Backport 2.x][MDS] Observability Datasource Plugin migration with MDS support for Data Connection Table #7371
Conversation
…nsearch-project#7143) * Observability Datasource Plugin migration with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Switch to use doc services for doc links of configuration of s3 datasource Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the snapshot for mds Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for data source creation panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq configuration Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add readonly for s3glue doc link Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for s3 prometheus creation and review Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix mount feature flag behavior and tests Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names again Signed-off-by: Ryan Liang <jiallian@amazon.com> * Experiment 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the visbuilder failure 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the setter of datasource setup in vis_type_timeseries Signed-off-by: Ryan Liang <jiallian@amazon.com> * Synced branch Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the readonly in doc link and add change log Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the create opensearch datasource's cancel button redirection Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add more test cases for breadscrumb changes and mount behavior based on the plugin registration Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com>
…nsearch-project#7163) * Fix the dsm plugin setup when mds feature flag is disabled Signed-off-by: Ryan Liang <jiallian@amazon.com> * Changeset file for PR opensearch-project#7163 created/updated --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7371 +/- ##
========================================
Coverage 68.03% 68.04%
========================================
Files 3478 3495 +17
Lines 68953 69252 +299
Branches 11250 11291 +41
========================================
+ Hits 46914 47122 +208
- Misses 19291 19361 +70
- Partials 2748 2769 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Liang <jiallian@amazon.com>
…S support for Data Connection Table (#7371) * [MDS] Observability Datasource Plugin migration with MDS support (#7143) * Observability Datasource Plugin migration with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Switch to use doc services for doc links of configuration of s3 datasource Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the snapshot for mds Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for data source creation panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq configuration Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add readonly for s3glue doc link Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for s3 prometheus creation and review Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix mount feature flag behavior and tests Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names again Signed-off-by: Ryan Liang <jiallian@amazon.com> * Experiment 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the visbuilder failure 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the setter of datasource setup in vis_type_timeseries Signed-off-by: Ryan Liang <jiallian@amazon.com> * Synced branch Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the readonly in doc link and add change log Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the create opensearch datasource's cancel button redirection Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add more test cases for breadscrumb changes and mount behavior based on the plugin registration Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> * [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163) * Fix the dsm plugin setup when mds feature flag is disabled Signed-off-by: Ryan Liang <jiallian@amazon.com> * Changeset file for PR #7163 created/updated --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Changeset file for PR #7371 created/updated * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 704f2fa) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…S support for Data Connection Table (#7371) (#7384) * [MDS] Observability Datasource Plugin migration with MDS support (#7143) * Observability Datasource Plugin migration with MDS support * Switch to use doc services for doc links of configuration of s3 datasource * Add tests for home panel * Fix the snapshot for mds * Add tests for data source creation panel * Add tests for dq data connection table * Add tests for dq configuration * Add readonly for s3glue doc link * Add tests for s3 prometheus creation and review * Fix mount feature flag behavior and tests * Shorten file names * Shorten file names again * Experiment 1 * Fix the visbuilder failure 1 * Fix the setter of datasource setup in vis_type_timeseries * Synced branch * Fix the readonly in doc link and add change log * Fix the create opensearch datasource's cancel button redirection * Add more test cases for breadscrumb changes and mount behavior based on the plugin registration --------- * [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163) * Fix the dsm plugin setup when mds feature flag is disabled * Changeset file for PR #7163 created/updated --------- * Changeset file for PR #7371 created/updated * Fix snapshots --------- (cherry picked from commit 704f2fa) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Ryan Liang jiallian@amazon.com
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration