Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][MDS] Observability Datasource Plugin migration with MDS support for Data Connection Table #7371

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Jul 22, 2024

Signed-off-by: Ryan Liang jiallian@amazon.com

Description

  • [MDS] Observability Datasource Plugin migration with MDS support
  • [MDS] Fix the dsm plugin setup when mds feature flag is disabled

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: [MDS] Observability Datasource Plugin migration with MDS support for Data Connection Table

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

RyanL1997 and others added 2 commits July 22, 2024 15:01
…nsearch-project#7143)

* Observability Datasource Plugin migration with MDS support

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Switch to use doc services for doc links of configuration of s3 datasource

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for home panel

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the snapshot for mds

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for data source creation panel

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for dq data connection table

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for dq configuration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add readonly for s3glue doc link

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for s3 prometheus creation and review

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix mount feature flag behavior and tests

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Shorten file names

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Shorten file names again

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Experiment 1

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the visbuilder failure 1

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the setter of datasource setup in vis_type_timeseries

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Synced branch

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the readonly in doc link and add change log

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the create opensearch datasource's cancel button redirection

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add more test cases for breadscrumb changes and mount behavior based on the plugin registration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
…nsearch-project#7163)

* Fix the dsm plugin setup when mds feature flag is disabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR opensearch-project#7163 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 71.24183% with 88 lines in your changes missing coverage. Please review.

Project coverage is 68.04%. Comparing base (a0eea7d) to head (148ab46).
Report is 4 commits behind head on 2.x.

Files Patch % Lines
...figuration/configure_direct_query_data_sources.tsx 53.94% 30 Missing and 5 partials ⚠️
...ion/manage_direct_query_data_connections_table.tsx 69.81% 12 Missing and 4 partials ⚠️
...guration/direct_query_data_source_auth_details.tsx 61.90% 7 Missing and 1 partial ⚠️
...tion/amazon_s3/configure_amazon_s3_data_source.tsx 63.15% 6 Missing and 1 partial ⚠️
...nnection/direct_query_data_source_delete_modal.tsx 50.00% 3 Missing and 1 partial ⚠️
...irect_query_data_source_configuration/name_row.tsx 86.36% 2 Missing and 1 partial ⚠️
...on/prometheus/configure_prometheus_data_source.tsx 72.72% 3 Missing ⚠️
...ry_data_source_configuration/query_permissions.tsx 78.57% 1 Missing and 2 partials ⚠️
...uration/amazon_s3/review_amazon_s3_data_source.tsx 66.66% 0 Missing and 2 partials ⚠️
...ation/prometheus/review_prometheus_data_source.tsx 66.66% 0 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff            @@
##              2.x    #7371    +/-   ##
========================================
  Coverage   68.03%   68.04%            
========================================
  Files        3478     3495    +17     
  Lines       68953    69252   +299     
  Branches    11250    11291    +41     
========================================
+ Hits        46914    47122   +208     
- Misses      19291    19361    +70     
- Partials     2748     2769    +21     
Flag Coverage Δ
Linux_1 33.17% <33.33%> (+<0.01%) ⬆️
Linux_2 55.58% <ø> (ø)
Linux_3 43.31% <71.61%> (+0.22%) ⬆️
Linux_4 34.97% <66.66%> (+0.01%) ⬆️
Windows_1 33.19% <33.33%> (+<0.01%) ⬆️
Windows_2 55.53% <ø> (ø)
Windows_3 43.32% <71.61%> (+0.21%) ⬆️
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@BionIT BionIT merged commit 704f2fa into opensearch-project:2.x Jul 22, 2024
65 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
…S support for Data Connection Table (#7371)

* [MDS] Observability Datasource Plugin migration with MDS support (#7143)

* Observability Datasource Plugin migration with MDS support

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Switch to use doc services for doc links of configuration of s3 datasource

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for home panel

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the snapshot for mds

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for data source creation panel

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for dq data connection table

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for dq configuration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add readonly for s3glue doc link

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for s3 prometheus creation and review

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix mount feature flag behavior and tests

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Shorten file names

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Shorten file names again

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Experiment 1

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the visbuilder failure 1

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the setter of datasource setup in vis_type_timeseries

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Synced branch

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the readonly in doc link and add change log

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the create opensearch datasource's cancel button redirection

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add more test cases for breadscrumb changes and mount behavior based on the plugin registration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163)

* Fix the dsm plugin setup when mds feature flag is disabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #7163 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* Changeset file for PR #7371 created/updated

* Fix snapshots

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 704f2fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Jul 23, 2024
…S support for Data Connection Table (#7371) (#7384)

* [MDS] Observability Datasource Plugin migration with MDS support (#7143)

* Observability Datasource Plugin migration with MDS support



* Switch to use doc services for doc links of configuration of s3 datasource



* Add tests for home panel



* Fix the snapshot for mds



* Add tests for data source creation panel



* Add tests for dq data connection table



* Add tests for dq configuration



* Add readonly for s3glue doc link



* Add tests for s3 prometheus creation and review



* Fix mount feature flag behavior and tests



* Shorten file names



* Shorten file names again



* Experiment 1



* Fix the visbuilder failure 1



* Fix the setter of datasource setup in vis_type_timeseries



* Synced branch



* Fix the readonly in doc link and add change log



* Fix the create opensearch datasource's cancel button redirection



* Add more test cases for breadscrumb changes and mount behavior based on the plugin registration



---------



* [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163)

* Fix the dsm plugin setup when mds feature flag is disabled



* Changeset file for PR #7163 created/updated

---------




* Changeset file for PR #7371 created/updated

* Fix snapshots



---------



(cherry picked from commit 704f2fa)

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants