Fix Discover not respecting searchOnPageLoad Advanced Setting #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7252 +/- ##
==========================================
+ Coverage 67.56% 67.62% +0.06%
==========================================
Files 3469 3471 +2
Lines 68479 68613 +134
Branches 11130 11165 +35
==========================================
+ Hits 46266 46399 +133
+ Misses 19511 19510 -1
- Partials 2702 2704 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
reviewed
Jul 16, 2024
| @@ -22,9 +22,6 @@ export default function DiscoverContext({ children }: React.PropsWithChildren<Vi | |||
| ...deServices, | |||
| ...services, | |||
| }); | |||
| searchParams.data$.next({ | |||
There was a problem hiding this comment.
Yup. This was introduced after 2.15.
LDrago27
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
virajsanghvi
as code owners
7 tasks
ashwin-pc
reviewed
Jul 16, 2024
ashwin-pc
approved these changes
Jul 16, 2024
ananzh
approved these changes
Jul 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Fixed Discover Canvas Status stuck in Loading state Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #7252 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 60ecd36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Jul 16, 2024
…#7262) * Fixed Discover Canvas Status stuck in Loading state * Changeset file for PR #7252 created/updated --------- (cherry picked from commit 60ecd36) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we set the searchOnPageLoad Advanced Setting as false , Upon navigating to Discover home page, we can see the page being stuck in a loading state. Refer the image below for reference.
Issues Resolved
Screenshot
Testing the changes
Adding a sample image for reference
Changelog
Check List
yarn test:jestyarn test:jest_integration