fix(discover): break new lines in table cell #7207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes opensearch-project#7177 Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7207 +/- ##
==========================================
- Coverage 67.57% 67.55% -0.02%
==========================================
Files 3469 3469
Lines 68479 68479
Branches 11130 11130
==========================================
- Hits 46276 46264 -12
- Misses 19500 19512 +12
Partials 2703 2703
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Jul 9, 2024
ananzh
approved these changes
Jul 25, 2024
ananzh
added
bug
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
* fix(discover): break new lines in table cell fixes #7177 Signed-off-by: Joshua Li <joshuali925@gmail.com> * Changeset file for PR #7207 created/updated --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4ff4c3c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
* fix(discover): break new lines in table cell fixes #7177 Signed-off-by: Joshua Li <joshuali925@gmail.com> * Changeset file for PR #7207 created/updated --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4ff4c3c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Jul 25, 2024
* fix(discover): break new lines in table cell fixes #7177 * Changeset file for PR #7207 created/updated --------- (cherry picked from commit 4ff4c3c) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 1, 2024
* fix(discover): break new lines in table cell fixes opensearch-project#7177 Signed-off-by: Joshua Li <joshuali925@gmail.com> * Changeset file for PR opensearch-project#7207 created/updated --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add
white-space: pre-wrap;back to table cell to fix regression in #7177Issues Resolved
fixes #7177
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration