Modify the adding sample data part for timeline #6919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyuanqi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba and
mengweieric
as code owners
zhyuanqi
added
multiple datasource
opensearch-changeset-bot bot
added a commit
to zhyuanqi/OpenSearch-Dashboards
that referenced
this pull request
Jun 5, 2024
zhyuanqi
force-pushed
the
timeline
branch
2 times, most recently
from
d62d922
to
d8fc98e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6919 +/- ##
=======================================
Coverage 67.42% 67.43%
=======================================
Files 3443 3443
Lines 67782 67806 +24
Branches 11027 11031 +4
=======================================
+ Hits 45705 45723 +18
- Misses 19412 19417 +5
- Partials 2665 2666 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhyuanqi
force-pushed
the
timeline
branch
2 times, most recently
from
4732241
to
dcb93eb
Compare
huyaboo
reviewed
Jun 5, 2024
| const replaceCallback = (match: string, funcName: string, args: string) => { | ||
| if (!args.includes('data_source_name')) { | ||
| args = args.trim(); | ||
| args = `${args}, data_source_name=${dataSourceTitle}`; |
There was a problem hiding this comment.
We should wrap the dataSourceTitle in "" since titles can have spaces (ex: dataSourceTitle="Some DataSource A")
Suggested change
| args = `${args}, data_source_name=${dataSourceTitle}`; | |
| args = `${args}, data_source_name="${dataSourceTitle}"`; |
There was a problem hiding this comment.
And update relevant test cases as well
There was a problem hiding this comment.
Thanks for pointing this out! Did not realize we can have name with space. Would modify and update test case
| @@ -111,12 +130,22 @@ export const extractVegaSpecFromSavedObject = (savedObject: SavedObject) => { | |||
| return undefined; | |||
| }; | |||
|
|
|||
| const isVegaVisualization = (savedObject: SavedObject) => { | |||
| export const extractTimelineExpression = (savedObject: SavedObject) => { | |||
| if (confirmVisualizationType(savedObject, 'timelion')) { | |||
There was a problem hiding this comment.
Nit: Logic should be the other way around. We should terminate early and return undefined if the visualization is not timelion
There was a problem hiding this comment.
Sure. Would make the change
45 tasks
zhyuanqi
force-pushed
the
timeline
branch
2 times, most recently
from
0150d0e
to
dc94610
Compare
huyaboo
approved these changes
Jun 5, 2024
BionIT
reviewed
Jun 5, 2024
zhyuanqi
force-pushed
the
timeline
branch
2 times, most recently
from
bf4ab28
to
8aa3af9
Compare
BionIT
reviewed
Jun 5, 2024
| const replaceCallback = (match: string, funcName: string, args: string) => { | ||
| if (!args.includes('data_source_name')) { | ||
| args = args.trim(); | ||
| args = `${args}, data_source_name="${dataSourceTitle}"`; |
There was a problem hiding this comment.
As best practice, we should not mutate the input, can we assign a new variable?
There was a problem hiding this comment.
Sure. Let me change the variable name.
zhyuanqi
force-pushed
the
timeline
branch
4 times, most recently
from
f88aca7
to
df5591d
Compare
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
BionIT
approved these changes
Jun 5, 2024
xinruiba
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> (cherry picked from commit 48144c8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhyuanqi
pushed a commit
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> (cherry picked from commit 48144c8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu
pushed a commit
that referenced
this pull request
Jun 6, 2024
(cherry picked from commit 48144c8) Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhyuanqi
added a commit
to zhyuanqi/OpenSearch-Dashboards
that referenced
this pull request
Jun 6, 2024
Merged
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the adding sample data part for timeline to add data source name if customer has enabled MDS
Issues Resolved
#6123
Screenshot
Screen.Recording.2024-06-05.at.12.26.50.AM.mov
Testing the changes
Please see screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration