-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft][OE] Adds TS check workflow #6586
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
uses: umani/changed-files@v4.0.0 | ||
with: | ||
repo-token: ${{ github.token }} | ||
pattern: '^.*\.ts$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pattern: '^.*\.ts$' | |
pattern: '^.*\.tsx?$' |
I guess tsx
should be included as well
include: '["\\.ts$"]' | ||
- name: Detecting files changed | ||
id: files | ||
uses: umani/changed-files@v4.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you consider https://github.com/tj-actions/changed-files which is more actively maintained?
@SuZhou-Joe @ruanyl , thanks for reviewing this. This PR isnt ready for review yet, but i cant put it in draft cause the CI wont run if it is, and i need it to test the github workflow. Will let you know once this is ready :) |
Hi @ashwin-pc , is this PR targeting 2.15 or 2.16? |
@BionIT This isnt targetting any specific release. This is an OE change that when i have the bandwith i'll try to get back to |
Description
Adds a TS check to the github workflow. This causes increases in TS Errors to be flagged and fail the CI
Issues Resolved
Screenshot
Testing the changes
The Typescript Check in the PR's CI should pass
Changelog
Check List
yarn test:jest
yarn test:jest_integration