Relax the use of ignoreVersionMismatch
#6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
ignore-version-mismatch
branch
from
84da554
to
b7ca9e0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6347 +/- ##
==========================================
- Coverage 67.51% 67.51% -0.01%
==========================================
Files 3377 3377
Lines 65843 65841 -2
Branches 10649 10648 -1
==========================================
- Hits 44455 44453 -2
+ Misses 18804 18803 -1
- Partials 2584 2585 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZilongX
approved these changes
Apr 4, 2024
ashwin-pc
approved these changes
Apr 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
) Signed-off-by: Miki <miki@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 6ab9065) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Apr 12, 2024
) (#6354) Signed-off-by: Miki <miki@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 6ab9065) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opensearch.ignoreVersionMismatchconfig had been limited to dev mode only. This change allows it to be entertained without that limitation.Check List
yarn test:jestyarn test:jest_integration