Add functional test cypress workflow improvements and enable the workflow for in-house tests #6061
Conversation
manasvinibs
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
manasvinibs
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6061 +/- ##
=======================================
Coverage 67.13% 67.13%
=======================================
Files 3318 3318
Lines 64037 64037
Branches 10266 10266
=======================================
+ Hits 42990 42992 +2
+ Misses 18549 18548 -1
+ Partials 2498 2497 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manasvinibs
changed the title
|
|
||
| "cypress:run-with-security": "env TZ=America/Los_Angeles NO_COLOR=1 cypress run --headless --env SECURITY_ENABLED=true,openSearchUrl=https://localhost:9200,WAIT_FOR_LOADER_BUFFER_MS=500", | ||
| "osd:ciGroup10": "echo \"dashboard_sanity_test_spec.js\"", | ||
| "osd:ciGroup11": "echo \"apps/vis_builder/*.js\"" |
There was a problem hiding this comment.
Created an issue to address this concern #6083
There was a problem hiding this comment.
Yea have we specified how we group the cypress tests within the dashboard repo into cigroups?
There was a problem hiding this comment.
Currently in Dashboards repo we are grouping it similar to how we group it in FT repo using package json by defining folder structure in it. I'll have to look into better way of doing it or something similar to how selenium tests are doing it today by passing it as a command.
…flow for in-house tests Add cigroup matrix for parallel runs Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
There was a problem hiding this comment.
Synced up with @manasvinibs offline, verified the cypress workflow on dashboard cypress tests.
| echo "DASHBOARDS_SPEC=${DASHBOARDS_SPEC}" >> $GITHUB_ENV | ||
|
|
||
| - name: Run FT repo tests | ||
| if: ${{ matrix.group < 10 }} |
There was a problem hiding this comment.
Do we plan to migrate all cypress test from FT repo into dashboard repo in the future?
There was a problem hiding this comment.
yes I think that will be ideal as we want feature and its tests to reside in the same place.
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6061-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89fcf63ca0790858143a97c3bfb47460214afc7e
# Push it to GitHub
git push --set-upstream origin backport/backport-6061-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
…flow for in-house tests (opensearch-project#6061) Add cigroup matrix for parallel runs Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 89fcf63) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
…flow for in-house tests (opensearch-project#6061) Add cigroup matrix for parallel runs Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 89fcf63) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
…flow for in-house tests (opensearch-project#6061) Add cigroup matrix for parallel runs Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 89fcf63) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
|
Manual backport #6139 |
Description
Addressing comments from this PR #5725
This way we can get the release testing verification workflow triggered with a dispatch event with a specified build. While the existing cypress test workflow will address the code within opened pull requests and run the tests.
Issues Resolved
#5892
Testing the changes
Look into CI workflow in the PR to verify the change in this PR: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/8184064533/job/22377905977?pr=6061
Check List
yarn test:jestyarn test:jest_integration