[osd/std] Add additional recovery from false-positives in handling of long numerals #5956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
AMoo-Miki
force-pushed
the
add-extra-recovery-for-long-numerals
branch
from
7fc8eac
to
c44ce2f
Compare
…ng numerals Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
add-extra-recovery-for-long-numerals
branch
from
c44ce2f
to
e77adaf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5956 +/- ##
==========================================
+ Coverage 67.01% 67.03% +0.01%
==========================================
Files 3310 3310
Lines 63647 63651 +4
Branches 10165 10165
==========================================
+ Hits 42656 42668 +12
+ Misses 18522 18514 -8
Partials 2469 2469
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
reviewed
Feb 26, 2024
|
The particular exception is only thrown in browsers. I have created an issue to add functional test to handle the new exception. The existing unit tests cover this case already. |
Signed-off-by: Miki <miki@amazon.com>
ashwin-pc
previously approved these changes
Feb 27, 2024
|
@AMoo-Miki can you link that issue here? |
|
Signed-off-by: Miki <miki@amazon.com>
ashwin-pc
approved these changes
Feb 27, 2024
manasvinibs
approved these changes
Feb 27, 2024
kavilla
approved these changes
Feb 27, 2024
gaobinlong
pushed a commit
to gaobinlong/OpenSearch-Dashboards
that referenced
this pull request
Feb 28, 2024
…ng numerals (opensearch-project#5956) Signed-off-by: Miki <miki@amazon.com>
abbyhu2000
added a commit
that referenced
this pull request
Mar 1, 2024
…ng numerals (#5956) (#5972) Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit a7ab795) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 4, 2024
…ng numerals (opensearch-project#5956) Signed-off-by: Miki <miki@amazon.com>
|
@AMoo-Miki Could you please confirm if this is going to be released to 2.12.0 as it's already labeled as backport with 2.12.0 ? |
|
@atreyd the 2.12 branch is not going to receive a new release as 2.13.0 is just around the corner. |
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The parsing of JSON strings with long numerals in @osd/std handled two false-positive scenarios. A new one was discovered where mixed escaped quotes inside a string value resulted in a different exception in browsers that the one already handled for Node.
Issues Resolved
Fixes #5923
Check List
yarn test:jestyarn test:jest_integration