Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Chore (ui-shared-deps): Clean up direct usage of OUI theme JSON #5680

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a4ae399 from #5662.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (25d560c) 67.06% compared to head (2c1344e) 35.46%.
Report is 3 commits behind head on 2.x.

Files Patch % Lines
...s/expressions/public/react_expression_renderer.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              2.x    #5680       +/-   ##
===========================================
- Coverage   67.06%   35.46%   -31.61%     
===========================================
  Files        3293     1871     -1422     
  Lines       63357    35972    -27385     
  Branches    10066     6494     -3572     
===========================================
- Hits        42492    12758    -29734     
- Misses      18422    22375     +3953     
+ Partials     2443      839     -1604     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 ?
Linux_4 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 35.46% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Chore (ui-shared-deps): Clean up direct usage of OUI theme JSON

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* add changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit a4ae399)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@manasvinibs manasvinibs merged commit 54aca34 into 2.x Jan 31, 2024
63 of 66 checks passed
@github-actions github-actions bot deleted the backport/backport-5662-to-2.x branch January 31, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants