[Fix] Duplicate Icon Rendering in Markdown Visualization Editor

[willie-hung]

Description

The revision makes the icon appear only once, aligning with the design of the user interface.

Issues Resolved

Resolves #5510

Screenshot

Before

After

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[willie-hung]

When this line is specified, the EuiLink component will render the popout icon, no need to render another EuiIcon in this case.

OpenSearch-Dashboards/src/plugins/vis_type_markdown/public/markdown_options.tsx

Line 70 in b21877b

target="_blank"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6ce6e7) 66.98% compared to head (b21877b) 66.98%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5511   +/-   ##
=======================================
  Coverage   66.98%   66.98%           
=======================================
  Files        3293     3293           
  Lines       63281    63281           
  Branches    10061    10061           
=======================================
  Hits        42389    42389           
  Misses      18451    18451           
  Partials     2441     2441           

Flag	Coverage Δ
Linux_1	35.24% <ø> (ø)
Linux_2	55.21% <ø> (ø)
Linux_3	43.79% <ø> (+0.01%)	⬆️
Linux_4	35.33% <ø> (ø)
Windows_1	35.27% <ø> (ø)
Windows_2	55.18% <ø> (ø)
Windows_3	43.80% <ø> (ø)
Windows_4	35.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshuarrrr]

When this line is specified, the EuiLink component will render the popout icon, no need to render another EuiIcon in this case.

OpenSearch-Dashboards/src/plugins/vis_type_markdown/public/markdown_options.tsx

Line 70 in b21877b

target="_blank"

@Willie-The-Lord Do you think we need to improve anything in the OUI docs site to prevent this sort of error elsewhere? https://oui.opensearch.org/1.3/#/navigation/link

From a quick scan, I can see that target="_blank" sets external to true, but I don't see any external links in the example or any explanation that the icon is included automatically.

[joshuarrrr]

Maintainers should also verify if this bug exists in 1.3.x.

[willie-hung]

From a quick scan, I can see that target="_blank" sets external to true, but I don't see any external links in the example or any explanation that the icon is included automatically.

@joshuarrrr Yeah, that's right! Here's the implementation of the OuiLink prop for your reference:

1. OuiIcon - popout
   https://github.com/Willie-The-Lord/oui/blob/24592a68111ab47d511fc250ed18ef03ccac6f25/src/components/link/link.tsx#L132-L139

2. the logic that render the popout icon
   https://github.com/Willie-The-Lord/oui/blob/24592a68111ab47d511fc250ed18ef03ccac6f25/src/components/link/link.tsx#L183-L184

I think we should raise a PR to add an explanation on the oui doc website for the OuiLink. What do you think? Thanks!

[willie-hung]

@joshuarrrr I've just raised a draft PR to make the ouiLink documentation more explicit. Please help verify whether it's the best place to put the explanation. Thanks!

[ananzh]

1.3 is still using eui and has no issue