Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering #5111

Merged

Conversation

abbyhu2000
Copy link
Member

Description

Fix functional group 3 failures for save search on dashboard filtering

Issues Resolved

resolves #5107

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #5111 (170894e) into feature/deangular (64f6746) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           feature/deangular    #5111      +/-   ##
=====================================================
- Coverage              66.69%   66.68%   -0.01%     
=====================================================
  Files                   3283     3283              
  Lines                  63059    63059              
  Branches               10031    10031              
=====================================================
- Hits                   42058    42053       -5     
- Misses                 18536    18545       +9     
+ Partials                2465     2461       -4     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.23% <ø> (ø)
Linux_3 43.66% <ø> (ø)
Linux_4 35.43% <ø> (ø)
Windows_1 35.27% <ø> (ø)
Windows_2 55.20% <ø> (ø)
Windows_3 43.66% <ø> (ø)
Windows_4 35.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@ashwin-pc ashwin-pc merged commit da3c209 into opensearch-project:feature/deangular Sep 26, 2023
46 of 52 checks passed
ashwin-pc added a commit that referenced this pull request Sep 29, 2023
* Basic working version of OSD without angular (#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081)

* [Data Explorer][Discover 2.0] Implement saved search embeddable

Issue Resolve
#4233

---------

Signed-off-by: ananzh <ananzh@amazon.com>

* Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer] Delete legacy discover selenium tests (#5088)

* delete legacy discover functional tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove discover folder in config file

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099)

* add data-render-complete and data-shared-item for test convenience
* change docTableFieldCount to dataGridTableCellCount to fetch data grid cell
* add methods in data grid service to reuse current massive selenium tests
* update tests

Issue Resolve
#5098
#5058

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104)

Update index pattern fetch method in discover page due to changing to EuiComboBox.

Issue Resolve
#5103

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix cigroup 1 with dataGridTable helper functions (#5105)

* fix1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix 1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix anchor test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix cigroup1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111)

* fix cigroup3

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix error

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add data-shared-item tag (#5119)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080)

Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>

* fix cigroup6 (#5125)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover] Search on load fix (#5112)

* fixes search on load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Fixes search after initial page load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131)

* [Data Explorer][Discover][Functional Test] Fix ciGroup7

Issue Resolve
#5129

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* restore _discover_navigation

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Deangular: removes angular from notify and utils of opendashboards legacy (#5085)

* Basic working version of OSD without angular (#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* deangularized notify and utils folders in the opendashboards legacy directory

Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

* [Discover] Misc fixes (#5114)

* Canvas scrolling fix, remove notice and improve flyout focus

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Hide action icons unless hovered or focussed on

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* followup fixes from #5085

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Co-authored-by: Cameron Reed <cameron.reed@oracle.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>
ashwin-pc added a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Oct 3, 2023
* Basic working version of OSD without angular (opensearch-project#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover 2.0] Implement saved search embeddable (opensearch-project#5081)

* [Data Explorer][Discover 2.0] Implement saved search embeddable

Issue Resolve
opensearch-project#4233

---------

Signed-off-by: ananzh <ananzh@amazon.com>

* Deangular: removes angular paginate, cleanup data plugin and tilemap (opensearch-project#5060)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer] Delete legacy discover selenium tests (opensearch-project#5088)

* delete legacy discover functional tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove discover folder in config file

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer][Discover][Function Test] Fix ciGroup4 (opensearch-project#5099)

* add data-render-complete and data-shared-item for test convenience
* change docTableFieldCount to dataGridTableCellCount to fetch data grid cell
* add methods in data grid service to reuse current massive selenium tests
* update tests

Issue Resolve
opensearch-project#5098
opensearch-project#5058

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Data Explorer][Discover][Functional Test] fix ciGroup 8 (opensearch-project#5104)

Update index pattern fetch method in discover page due to changing to EuiComboBox.

Issue Resolve
opensearch-project#5103

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix cigroup 1 with dataGridTable helper functions (opensearch-project#5105)

* fix1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix 1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix anchor test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix cigroup1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (opensearch-project#5111)

* fix cigroup3

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix error

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add data-shared-item tag (opensearch-project#5119)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (opensearch-project#5080)

Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>

* fix cigroup6 (opensearch-project#5125)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover] Search on load fix (opensearch-project#5112)

* fixes search on load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Fixes search after initial page load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover][Functional Test] Fix ciGroup7 (opensearch-project#5131)

* [Data Explorer][Discover][Functional Test] Fix ciGroup7

Issue Resolve
opensearch-project#5129

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* restore _discover_navigation

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Deangular: removes angular from notify and utils of opendashboards legacy (opensearch-project#5085)

* Basic working version of OSD without angular (opensearch-project#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* deangularized notify and utils folders in the opendashboards legacy directory

Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

* [Discover] Misc fixes (opensearch-project#5114)

* Canvas scrolling fix, remove notice and improve flyout focus

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Hide action icons unless hovered or focussed on

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* followup fixes from opensearch-project#5085

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Co-authored-by: Cameron Reed <cameron.reed@oracle.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>
(cherry picked from commit 0557ab1)
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
AMoo-Miki pushed a commit that referenced this pull request Oct 4, 2023
* [Deangular] OSD without angular (#5086)

* Basic working version of OSD without angular (#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081)

* [Data Explorer][Discover 2.0] Implement saved search embeddable

Issue Resolve
#4233

---------

Signed-off-by: ananzh <ananzh@amazon.com>

* Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer] Delete legacy discover selenium tests (#5088)

* delete legacy discover functional tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove discover folder in config file

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099)

* add data-render-complete and data-shared-item for test convenience
* change docTableFieldCount to dataGridTableCellCount to fetch data grid cell
* add methods in data grid service to reuse current massive selenium tests
* update tests

Issue Resolve
#5098
#5058

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104)

Update index pattern fetch method in discover page due to changing to EuiComboBox.

Issue Resolve
#5103

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix cigroup 1 with dataGridTable helper functions (#5105)

* fix1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix 1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix anchor test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix cigroup1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111)

* fix cigroup3

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix error

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add data-shared-item tag (#5119)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080)

Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>

* fix cigroup6 (#5125)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover] Search on load fix (#5112)

* fixes search on load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Fixes search after initial page load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131)

* [Data Explorer][Discover][Functional Test] Fix ciGroup7

Issue Resolve
#5129

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* restore _discover_navigation

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Deangular: removes angular from notify and utils of opendashboards legacy (#5085)

* Basic working version of OSD without angular (#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* deangularized notify and utils folders in the opendashboards legacy directory

Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

* [Discover] Misc fixes (#5114)

* Canvas scrolling fix, remove notice and improve flyout focus

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Hide action icons unless hovered or focussed on

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* followup fixes from #5085

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Co-authored-by: Cameron Reed <cameron.reed@oracle.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>
(cherry picked from commit 0557ab1)
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* fixes snapshot

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Co-authored-by: Cameron Reed <cameron.reed@oracle.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>
AMoo-Miki pushed a commit that referenced this pull request Oct 4, 2023
* [Deangular] OSD without angular (#5086)

* Basic working version of OSD without angular (#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081)

* [Data Explorer][Discover 2.0] Implement saved search embeddable

Issue Resolve
#4233

---------

Signed-off-by: ananzh <ananzh@amazon.com>

* Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer] Delete legacy discover selenium tests (#5088)

* delete legacy discover functional tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove discover folder in config file

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099)

* add data-render-complete and data-shared-item for test convenience
* change docTableFieldCount to dataGridTableCellCount to fetch data grid cell
* add methods in data grid service to reuse current massive selenium tests
* update tests

Issue Resolve
#5098
#5058

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104)

Update index pattern fetch method in discover page due to changing to EuiComboBox.

Issue Resolve
#5103

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix cigroup 1 with dataGridTable helper functions (#5105)

* fix1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix 1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix anchor test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix cigroup1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111)

* fix cigroup3

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix error

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add data-shared-item tag (#5119)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080)

Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>

* fix cigroup6 (#5125)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover] Search on load fix (#5112)

* fixes search on load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Fixes search after initial page load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131)

* [Data Explorer][Discover][Functional Test] Fix ciGroup7

Issue Resolve
#5129

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* restore _discover_navigation

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Deangular: removes angular from notify and utils of opendashboards legacy (#5085)

* Basic working version of OSD without angular (#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* deangularized notify and utils folders in the opendashboards legacy directory

Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

* [Discover] Misc fixes (#5114)

* Canvas scrolling fix, remove notice and improve flyout focus

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Hide action icons unless hovered or focussed on

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* followup fixes from #5085

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Co-authored-by: Cameron Reed <cameron.reed@oracle.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>
(cherry picked from commit 0557ab1)
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* fixes snapshot

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Co-authored-by: Cameron Reed <cameron.reed@oracle.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project de-angular de-angularize work test:functional
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants