Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix buildPointSeriesData unit test fails due to local timezone #4992

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[BUG] Fix buildPointSeriesData unit test fails due to local timezone #4992

merged 1 commit into from
Sep 15, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Sep 12, 2023

Description

#4865 (comment)

Issues Resolved

#4865

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added bug Something isn't working test:unit discover for discover reinvent labels Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #4992 (624ab4a) into main (80fe14d) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4992   +/-   ##
=======================================
  Coverage   66.49%   66.49%           
=======================================
  Files        3402     3402           
  Lines       65011    65011           
  Branches    10401    10401           
=======================================
+ Hits        43230    43232    +2     
+ Misses      19212    19211    -1     
+ Partials     2569     2568    -1
Flag Coverage Δ
Linux_1 34.80% <ø> (ø)
Linux_2 55.31% <ø> (ø)
Linux_3 44.61% <ø> (+<0.01%) ⬆️
Linux_4 34.89% <ø> (ø)
Windows_1 34.81% <ø> (ø)
Windows_2 55.27% <ø> (ø)
Windows_3 44.61% <ø> (ø)
Windows_4 34.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@kavilla kavilla merged commit 195417b into opensearch-project:main Sep 15, 2023
69 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 15, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 15, 2023
@github-actions
[BUG] Fix buildPointSeriesData unit test fails due to local timezone (#…
8df7d80 
…4992)

Issue Resolved
#4865

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit 195417b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr pushed a commit that referenced this pull request Sep 22, 2023
@opensearch-trigger-bot @github-actions
[BUG] Fix buildPointSeriesData unit test fails due to local timezone (#…
2eea156 
…4992) (#5031)

Issue Resolved
#4865

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit 195417b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees

@ashwin-pc ashwin-pc

@ananzh ananzh

Labels
backport 2.x bug Something isn't working discover for discover reinvent distinguished-contributor test:unit v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananzh @ashwin-pc @abbyhu2000 @kavilla